8000 Restrict watchdog dependency by di · Pull Request #101 · GoogleCloudPlatform/functions-framework-python · GitHub
[go: up one dir, main page]
Skip to content

Restrict watchdog dependency #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

Restrict watchdog dependency #101

merged 1 commit into from
Dec 23, 2020

Conversation

di
Copy link
Member
@di di commented Dec 18, 2020

Fixes #100.

@google-cla google-cla bot added the cla: yes label Dec 18, 2020
@di di requested a review from grant December 18, 2020 21:50
@di di merged commit 75a8972 into master Dec 23, 2020
@di di deleted the fix/100 branch December 23, 2020 17:51
@MichaelKarpe MichaelKarpe mentioned this pull request May 3, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2022
@MichaelKarpe
feat: allow for watchdog>=2.0.0 (#186)
b4ed666 
`mkdocs>=1.2.2` [depends on](https://github.com/mkdocs/mkdocs/blob/cdf8a26cafa6af6cc78a45766dfec235bd7286cc/setup.py#L69) `watchdog>=2.0` and the restriction of watchdog dependency for functions-framework-python done in #101 seems to be due [an issue related to watchdog built distributions](gorakhargosh/watchdog#689 (comment)) (as explained by @di) which is [now fixed](gorakhargosh/watchdog#807).

I propose to allow for `watchdog>=2.0.0` so that a project can use both `mkdocs>=1.2.2` (or `watchdog>=2.0.0`) and `functions-framework-python>=3.0.0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing on macOS fails due to failed watchdog installation
2 participants
@di @grant
0