8000 chore: add GCF buildpack integration test Workflow by grant · Pull Request #127 · GoogleCloudPlatform/functions-framework-php · GitHub
[go: up one dir, main page]
Skip to content

chore: add GCF buildpack integration test Workflow #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: add GCF buildpack integration test Workflow #127

wants to merge 2 commits into from

Conversation

grant
Copy link
Contributor
@grant grant commented Jun 6, 2022 •
edited
Loading

Test. Adding buildpack integ test.

pack build test-fast --verbose \
--builder us.gcr.io/fn-img/buildpacks/php74/builder:php74_20220531_7_4_29_RC00 \
--env GOOGLE_RUNTIME=php74 \
--env GOOGLE_FUNCTION_TARGET=declarativeHttpFunc

Not sure about the prerun script.

grant added 2 commits June 6, 2022 15:29
@grant
ci: add buildpack integ test
292e2e1 
Signed-off-by: Grant Timmerman <744973+grant@users.noreply.github.com>
@grant
ci: remove local install
46d30b0 
Signed-off-by: Grant Timmerman <744973+grant@users.noreply.github.com>
grant
grant commented Jun 13, 2022
View reviewed changes
tests/conformance/composer.json
@@ -0,0 +1,6 @@
{
"require": {
"google/cloud-functions-framework": "*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change:

"google/cloud-functions-framework": "https://github.com/GoogleCloudPlatform/functions-framework-php/#commit=abc"

Need to pass SHA to this file.

@grant grant changed the title ci: add buildpack integ test chore: add GCF buildpack integration test Workflow Jun 16, 2022
@anniefu
Copy link
Contributor
anniefu commented Jun 24, 2022

Closing this one in favor of #129, which has some updates

@anniefu anniefu closed this Jun 24, 2022
@grant
Copy link
Contributor Author
grant commented Jun 24, 2022

Sure.

@grant grant deleted the grant_buildpack_integ branch June 24, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @anniefu
0