8000 Salesforce source and sink code · Pull Request #34 · GoogleCloudPlatform/DataflowJavaSDK · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Salesforce source and sink code#34

Closed
ghost wants to merge 8 commits intoGoogleCloudPlatform:masterfrom
egen:master
Closed

Salesforce source and sink code#34
ghost wants to merge 8 commits intoGoogleCloudPlatform:masterfrom
egen:master

Conversation

@ghost
Copy link
@ghost ghost commented Jun 6, 2015

We've been working with Eric Anderson at Google on Salesforce connectors. Here's our first version of the prototype code that we demo'd to Eric.

@googlebot
Copy link
googlebot commented Jun 6, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link
Author
ghost commented Jun 6, 2015

We signed the CLA as a corporation. Our company is springML.

@googlebot
Copy link
googlebot commented Jun 9, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@ghost
Copy link
Author
ghost commented Jun 9, 2015

CLA signed

@googlebot
Copy link
googlebot commented Jun 9, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ghost
Copy link
Author
ghost commented Jun 9, 2015

Confirming that I did the commits.

@davorbonaci
Copy link
Contributor
davorbonaci commented Jun 9, 2015

Hi there,
We are looking into these and will get back to you shortly with our comments, if any.

Thanks for your contribution!

@Aki11es
Copy link
Aki11es commented Jun 10, 2015

Cool!

@davorbonaci
Copy link
Contributor
davorbonaci commented Aug 11, 2015

Note: a fork seems to have been pushed to https://github.com/springml/dataflow-salesforce repository.

@davorbonaci davorbonaci self-assigned this Aug 11, 2015
@davorbonaci
Copy link
Contributor
davorbonaci commented Aug 11, 2015

CLA confirmed.

@dhalperi dhalperi assigned dhalperi and unassigned davorbonaci Oct 1, 2015
@dhalperi
Copy link
Contributor
dhalperi commented Oct 1, 2015

@springml I apologize profusely for the ludicrous delay here. I'm in the process of finding and picking up the balls we've dropped.

I see you are now serving the code this connector in the repo https://github.com/springml/dataflow-salesforce linked above. Do you still wish it to be contributed into this GoogleCloudPlatform repository?

@ghost
Copy link
Author
ghost commented Oct 3, 2015

Hello Daniel,

Yes we would like to contribute to GCP repo. Please let me know next steps.

Thank you.

-Girish
On Sep 30, 2015 8:58 PM, "Daniel Halperin" notifications@github.com wrote:

@springml https://github.com/springml I apologize profusely for the
ludicrous delay here. I'm in the process of finding and picking up the
balls we've dropped.

I see you are now serving the code this connector in the repo
https://github.com/springml/dataflow-salesforce linked above. Do you
still wish it to be contributed into this GoogleCloudPlatform repository?

—
Reply to this email directly or view it on GitHub
#34 (comment)
.

@ghost
Copy link
Author
ghost commented Feb 9, 2016

Moving to springml's github repo in light of dataflow becoming an apache project - will follow and contribute to the new project.

@ghost ghost closed this Feb 9, 2016
@davorbonaci
Copy link
Contributor
davorbonaci commented Feb 9, 2016

Thanks guys!

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dhalperi dhalperi

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@googlebot @davorbonaci @Aki11es @dhalperi @greddygit
0