core(render-blocking): use trace engine as the source of truth #15839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you assess the differences between our logic in TabsBlockingFirstPaint and using the blink signal? ref #2065 (comment) |
|
I verified that our expectations in dbw smoke test are the same but did not inspect the raw data. |
|
Looks like this is working, but we will need to wait for M123 to be stable before we think about shipping this |
adamraine
commented
Apr 10, 2024
| @@ -829,6 +829,9 @@ class TraceProcessor { | |||
| /** @param {number=} ts */ | |||
| const maybeGetTiming = (ts) => ts === undefined ? undefined : getTiming(ts); | |||
|
|
|||
| const navigationId = timeOriginEvt.args.data?.navigationId; | |||
| if (!navigationId) throw new Error('No navigation ID'); | |||
There was a problem hiding this comment.
Several old traces don't have this event...so may need to update them or do a workaround
connorjclark
approved these changes
Apr 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2065
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5250877
Uses the new
RenderBlockinginsight in the trace engine to find render blocking requests. Also eliminates the need for theTagsBlockingFirstPaintartifact.