Fix showing unmute user message action just after muting the user #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c5cab5 to
8f98355
Compare
SDK Size
|
10000
|
nuno-vieira
reviewed
Jun 2, 2025
| @@ -469,6 +471,7 @@ | |||
| <attribute name="lastActivityAt" optional="YES" attributeType="Date" usesScalarValueType="NO"/> | |||
| <attribute name="name" optional="YES" attributeType="String"/> | |||
| <attribute name="teams" attributeType="Transformable" valueTransformerName="NSSecureUnarchiveFromDataTransformer"/> | |||
| <attribute name="teamsRole" optional="YES" attributeType="Transformable" valueTransformerName="NSSecureUnarchiveFromDataTransformer"/> | |||
There was a problem hiding this comment.
Why has this file changed? 🤔
There was a problem hiding this comment.
Because we have a copy of the CoreData model (historical reasons as what I understand) and it was updated to set teamsRole when creating UserDTO. This unit-test is special because current user controller is accessed from the message actions and it requires data in the database.
nuno-vieira
reviewed
Jun 2, 2025
martinmitrevski
approved these changes
Jun 3, 2025
nuno-vieira
approved these changes
Jun 4, 2025
# Conflicts: # CHANGELOG.md
8f98355 to
bc7b0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-476
🎯 Goal
Unmute user did not appear because of comparing user objects, not ids
📝 Summary
🛠 Implementation
ChatUser equality changed awhile ago where it just comparing ids, it compares other properties as well. This broke this check.
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo