8000 Fix `ChatChannelView` keyboard background not using color from palette by nuno-vieira · Pull Request #845 · GetStream/stream-chat-swiftui · GitHub
[go: up one dir, main page]
Skip to content

Fix ChatChannelView keyboard background not using color from palette #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

Fix ChatChannelView keyboard background not using color from palette #845

merged 4 commits into from
May 30, 2025

Conversation

nuno-vieira
Copy link
Member
@nuno-vieira nuno-vieira commented May 29, 2025 •
edited
Loading

🔗 Issue Links

IOS-852

🎯 Goal

  • Fix ChatChannelView keyboard background not using color from palette

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner May 29, 2025 15:52
@nuno-vieira nuno-vieira changed the title Allow customizing Channel Background Allow customizing ChatChannelView Background May 29, 2025
@Stream-SDK-Bot
Copy link
Collaborator
Stream-SDK-Bot commented May 29, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.25 MB 8.27 MB +16 KB 🟢

nuno-vieira
nuno-vieira commented May 29, 2025
View reviewed changes
@nuno-vieira nuno-vieira force-pushed the add/customizing-channel-view-background branch from a0aee06 to 1796263 Compare May 29, 2025 17:35
@nuno-vieira nuno-vieira changed the title Allow customizing ChatChannelView Background Fix ChatChannelView keyboard background not using color from palette May 29, 2025
@nuno-vieira nuno-vieira changed the title Fix ChatChannelView keyboard background not using color from palette Fix ChatChannelView keyboard background not using color from palette May 29, 2025
laevandus
laevandus reviewed May 30, 2025
View reviewed changes
Sources/StreamChatSwiftUI/ChatChannel/ChatChannelView.swift Outdated
Comment on lines 198 to 201
).background(
TabBarAccessor { _ in
self.tabBarAvailable = utils.messageListConfig.handleTabBarVisibility
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one also have the isIphone check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually removed the isIphone check on the color as well, to improve it on iPad too

@nuno-vieira nuno-vieira enabled auto-merge (squash) May 30, 2025 11:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nuno-vieira nuno-vieira merged commit c03aa36 into develop May 30, 2025
11 checks passed
@nuno-vieira nuno-vieira deleted the add/customizing-channel-view-background branch May 30, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laevandus laevandus laevandus left review comments

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuno-vieira @Stream-SDK-Bot @laevandus @martinmitrevski
0