8000 Fix/pin unpin not working for messages with attachments by nuno-vieira · Pull Request #842 · GetStream/stream-chat-swiftui · GitHub
[go: up one dir, main page]
Skip to content

Fix/pin unpin not working for messages with attachments #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you a 8000 ccount related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

Fix/pin unpin not working for messages with attachments #842

merged 2 commits into from
May 28, 2025

Conversation

nuno-vieira
Copy link
Member
@nuno-vieira nuno-vieira commented May 28, 2025 •
edited
Loading

🔗 Issue Links

Regression found in https://linear.app/stream/issue/IOS-893/release-4790

🎯 Goal

  • Fix showing read count for pending or failed editing messages
  • Fix pin and unpinning a message not re-rendering message view

🧪 Manual Testing Notes

  1. Pin / Unpin message with or without attachments
  2. Should show PINNED UI

--

  1. Wi-fi OFF
  2. Edit a message with read count indicators
  3. Should show "Clock" icon
  4. When failed
  5. Should show error indicator and no read indicators

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner May 28, 2025 15:54
@github-actions GitHub Actions
Copy link
1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.23 MB 8.25 MB +17 KB 🟢

@nuno-vieira nuno-vieira merged commit 0541496 into develop May 28, 2025
11 checks passed
@nuno-vieira nuno-vieira deleted the fix/pin-unpin-not-working-for-messages-with-attachments branch May 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @martinmitrevski
0