8000 Fix translated message showing original text in message actions overlay by nuno-vieira · Pull Request #810 · GetStream/stream-chat-swiftui · GitHub
[go: up one dir, main page]

Skip to content

Fix translated message showing original text in message actions overlay #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Conversation

nuno-vieira
Copy link
Member
@nuno-vieira nuno-vieira commented Apr 21, 2025

🔗 Issue Links

https://linear.app/stream/issue/IOS-763/swiftui-translated-text-not-shown-for-long-pressed-message

🎯 Goal

Fix translated message showing original text in message actions overlay.

🛠 Implementation

In the reactions overlay view, the MessageView did not have the .environment(\.channelTranslationLanguage).

🧪 Manual Testing Notes

  1. Long tap a translated message
  2. Should show the translated text in the overlay view

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner April 21, 2025 15:42
@Stream-SDK-Bot
Copy link
Collaborator
Stream-SDK-Bot commented Apr 21, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.23 MB 8.23 MB 0 KB 🟢

Copy link

@nuno-vieira nuno-vieira merged commit fb71e2c into develop Apr 21, 2025
12 checks passed
@nuno-vieira nuno-vieira deleted the fix/translated-message-shows-original-text-in-message-actions-overlay branch April 21, 2025 21:41
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0