-
Notifications
You must be signed in to change notification settings - Fork 99
Add support for bounced message alert actions #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size
|
@@ -89,6 +89,15 @@ open class ChatChannelViewModel: ObservableObject, MessagesDataSource { | |||
} | |||
} | |||
|
|||
public private(set) var bouncedMessage: ChatMessage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be @Published
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment I don't need it to be, but could be useful for customers maybe 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -32,6 +32,7 @@ public struct MessageListConfig { | |||
isMessageEditedLabelEnabled: Bool = true, | |||
markdownSupportEnabled: Bool = true, | |||
userBlockingEnabled: Bool = false, | |||
bouncedMessagesAlertActionsEnabled: Bool = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use true here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Toomas Vahter <toomas.vahter@getstream.io>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks great!
🔗 Issue Link
https://linear.app/stream/issue/IOS-713/add-moderation-flow-bounce-to-swiftui
🎯 Goal
Adds support for bounced message alert actions. This new UI is aligned with UIKit and other platforms, including the Figma design files. In order to avoid introducing a breaking change, a new
MessageListConfig.bouncedMessagesAlertActionsEnabled
has been introduced.🧪 Testing
Pre-condition:
The following git patch should be applied to include the environment for bounced messages:
bounce-demo.patch
Scenario:
🎨 Changes
☑️ Checklist