8000 Filter deactivated users in channel info view by martinmitrevski · Pull Request #758 · GetStream/stream-chat-swiftui · GitHub
[go: up one dir, main page]
Skip to content

Filter deactivated users in channel info view #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

Filter deactivated users in channel info view #758

merged 3 commits into from
Feb 17, 2025

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves https://linear.app/stream/issue/IOS-659/filter-out-deactivated-users-in-channel-info-view.

🎯 Goal

Filter deactivated user in channel info view.

🛠 Implementation

Added a flag in the ParticipantInfo model and used it for filtering.

🧪 Testing

Covered by snapshot tests.

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner February 17, 2025 13:23
@Stream-SDK-Bot
Copy link
Collaborator
Stream-SDK-Bot commented Feb 17, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.58 MB 7.59 MB +16 KB 🟢

nuno-vieira
nuno-vieira approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Would be nice to get the tests passing first

@martinmitrevski martinmitrevski enabled auto-merge (squash) February 17, 2025 16:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@martinmitrevski martinmitrevski merged commit b4cf74b into develop Feb 17, 2025
11 of 12 checks passed
@martinmitrevski martinmitrevski deleted the filter-deactivated branch February 17, 2025 16:43
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmitrevski @Stream-SDK-Bot @nuno-vieira
0