8000 Fix Xcode 13 beta 3 AppExtension compilation by DominikBucher12 · Pull Request #1333 · GetStream/stream-chat-swift · GitHub
[go: up one dir, main page]
Skip to content

Fix Xcode 13 beta 3 AppExtension compilation #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2021
Merged

Fix Xcode 13 beta 3 AppExtension compilation #1333

merged 2 commits into from
Aug 2, 2021

Conversation

DominikBucher12
Copy link
Contributor
@DominikBucher12 DominikBucher12 commented Jul 30, 2021 •
edited
Loading

What this PR do:

  • Fix SDK compilation issue for Xcode 13 beta 3 by marking functions leading to calling UIApplication.shared.open as unavailable for iOSAppExtension

How to test it

  • Run Attached demo project in Xcode 13 beta 3 and see if it compiles.
    TestingApp.zip

SPM Team is looking for different solutions to the problem, you can take a look at discussion here:

https://forums.swift.org/t/set-application-extension-api-only-on-a-spm-package/39333/24

@DominikBucher12 DominikBucher12 linked an issue Jul 30, 2021 that may be closed by this pull request
SDK does not compile in XCode 13.0 beta 3 #1319
Closed
@codecov-commenter
Copy link
codecov-commenter commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #1333 (ebfd311) into main (0cbf1a0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   91.15%   91.17%   +0.02%     
==========================================
  Files         227      227              
  Lines        9763     9763              
==========================================
+ Hits         8899     8901       +2     
+ Misses        864      862       -2
Flag Coverage Δ
llc-tests 91.01% <ø> (+0.02%) ⬆️
llc-tests-ios12 87.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/StreamChat/Utils/Logger/Logger.swift 82.27% <0.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbf1a0...ebfd311. Read the comment docs.

@tbarbugli tbarbugli mentioned this pull request Aug 2, 2021
Closed
@SagarSDagdu SagarSDagdu self-requested a review August 2, 2021 11:35
SagarSDagdu
SagarSDagdu approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor
@SagarSDagdu SagarSDagdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@DominikBucher12 DominikBucher12 merged commit e13ed8c into main Aug 2, 2021
@DominikBucher12 DominikBucher12 deleted the Fix_Xcode13Beta_AppExtensionCompilation branch August 2, 2021 11:36
@marandaneto marandaneto mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbarbugli tbarbugli Awaiting requested review from tbarbugli

6F43 @b-onc b-onc Awaiting requested review from b-onc

2 more reviewers

@dmigach dmigach dmigach approved these changes

@SagarSDagdu SagarSDagdu SagarSDagdu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK does not compile in XCode 13.0 beta 3
4 participants
@DominikBucher12 @codecov-commenter @dmigach @SagarSDagdu
0