E521 Add index definitions to the data dictionary form/Separate index form by beeyayjay · Pull Request #4375 · GetDKAN/dkan · GitHub
[go: up one dir, main page]
Skip to content

Add index definitions to the data dictionary form/Separate index form #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 31 commits into
base: 2.x
Choose a base branch
from
Draft

Add index definitions to the data dictionary form/Separate index form #4375

wants to merge 31 commits into from

Conversation

@beeyayjay
Copy link
Contributor
@beeyayjay beeyayjay commented Jan 6, 2025

Separate edit screens for data dictionary indexes.

Known bugs:

  • Index name and type aren't saved
  • When editing index fields, Cancel button doesn't work.
  • Index field validation doesn't work
  • Add index doesn't work

kaise-lafrai and others added 30 commits January 6, 2025 15:28
@kaise-lafrai
Initial commit of updates to include indexes and index fields to the …
2c2d0e4 
…data dictionary
@kaise-lafrai
Added working cancel button for index, fixed errors appearing in log
5396653
@kaise-lafrai
Removed unused code, fixed index fields cancel button
bb42cf8
@kaise-lafrai
Added validation for index fields form, refactored code, refactored t…
5e0ee4c 
…ests
@kaise-lafrai
Fully functional edit experience for index fields (#4204)
e529acc
@kaise-lafrai
Editable Index (#4239)
620bced
@dmundra
Index UI unit tests (#4262)
2250243
@dmundra
Updated data dictionary widget functional test to test all fields in …
b7f844b 
…the form and the data dictionary and index field displays. (#4265)
@dmundra
Added Indexes edit unit tests (#4266)
b10bd49
@dmundra
Some simple code cleanup (white space, removal of commented out code,…
567107f 
… arrays, comment updates).
@rovcase
WCMS-20047: Data Dictionary Documentation (#4271)
a9ccde9
@dmundra
Data dictionary indexes code refactoring (#4280)
bb76f74
@dmundra
Reverted changes to checkIndexEditingField and checkIndexEditing. Upd…
c7d7cfe 
…ated comment.
@dmundra
Adding code comments. (#4289)
4b4cf50
@rovcase
Dictionary-Widget: Streamline the button labels for the Index and Ind…
ea018c7 
…ex Fields (#4324)
Provisional commit
ffb4d44
In progress
ae7e367
Added indexes to admin view.
a320129
Temp save
53fe56f
Temp save
0d46835
Temp save
2f45d07
Temp save
ec4fdf8
Index keyname changes and bug fixes.
058a91a
Other indexes.
1f3c275
Index edit works.
982d12f
Add index field and cancel work.
326d0b5
Some cleanup.
69ee91f
More stuff
622f4a9
Some cleanup
c9b743b
Updated data dictionary admin list. Added 'Add index' link.
3e82443
@beeyayjay beeyayjay force-pushed the wcms-WCMS-23755-data-dict-index branch from 318db72 to a3bf332 Compare January 6, 2025 20:34
@janette janette changed the title [WIP] WCMS-23755: Data dictionary index - DO NOT MERGE Separate index form - DO NOT MERGE Jan 6, 2025
@janette janette marked this pull request as draft January 6, 2025 22:09
@janette janette changed the title Separate index form - DO NOT MERGE Add index definitions to the data dictionary form/Separate index form - DO NOT MERGE Jan 6, 2025
@dafeder dafeder changed the title Add index definitions to the data dictionary form/Separate index form - DO NOT MERGE Add index definitions to the data dictionary form/Separate index form Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@beeyayjay @kaise-lafrai @dmundra @rovcase
0