8000 skip index errors on 2d points z,m bounding boxes by petrchpetr · Pull Request #128 · GeospatialPython/pyshp · GitHub
[go: up one dir, main page]
Skip to content

skip index errors on 2d points z,m bounding boxes #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

skip index errors on 2d points z,m bounding boxes #128

wants to merge 2 commits into from

Conversation

petrchpetr
Copy link

I have a file with 2d points and Writer's class __mbox and __zbox fails because of missing dimensions.
I added pass on IndexError similar to existing solution in other functions. Please, review if this is an acceptable solution.

@karimbahgat
Copy link
Collaborator

Thanks for pointing out these bugs with z and m box. I've now implemented them in 34274a8 with some modifications. It seems the problem with IndexError wasn't the missing z or m values, but rather that the previous code for updating the file z/mbox was based on the normal bbox, assuming four values. The z/mbox should only have two values (m/zmin,m/zmax).

And great suggestion on handling incorrect file lengths in the shp header, though I think that should warrant a separate PR with additional checks (laid out as a new issue in #147).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrchpetr @karimbahgat
0