10000 Remove the variable GMT_SHAREDIR from CI settings by seisman · Pull Request #437 · GenericMappingTools/pygmt · GitHub
[go: up one dir, main page]
Skip to content

Remove the variable GMT_SHAREDIR from CI settings #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

Remove the variable GMT_SHAREDIR from CI settings #437

merged 1 commit into from
May 20, 2020

Conversation

seisman
Copy link
Member
@seisman seisman commented May 20, 2020

Description of proposed changes

The variable GMT_SHAREDIR was needed due to a GMT 6.0.0 bug. See GenericMappingTools/gmt#3353 for the bug report, and GenericMappingTools/gmt#3361 for the fix.

The conda GMT package was rebuilt in conda-forge/gmt-feedstock#94, in which the patch was applied to GMT 6.0.0.

Now PyGMT should work well with no need to add the variable GMT_SHAREDIR.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman
Remove the variable GMT_SHAREDIR from CI settings
ec4f63a 
The variable GMT_SHAREDIR was needed due to a GMT bug.
See GenericMappingTools/gmt#3353 for the bug report,
and GenericMappingTools/gmt#3361 for the fix.

The conda GMT package was rebuilt in conda-forge/gmt-feedstock#94,
in which the patch was applied to GMT 6.0.0.

Now PyGMT should work well with no need to add the variable GMT_SHAREDIR.
@seisman seisman closed this May 20, 2020
@seisman seisman reopened this May 20, 2020
@seisman seisman requested review from leouieda and weiji14 May 20, 2020 10:58
@seisman seisman merged commit deaa5e1 into master May 20, 2020
@seisman seisman deleted the sharedir branch May 20, 2020 12:03
This was referenced May 20, 2020
Merged
Closed
@seisman seisman mentioned this pull request May 21, 2020
Merged
8 tasks
@seisman seisman added this to the 0.1.x milestone May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leouieda leouieda Awaiting requested review from leouieda

@weiji14 weiji14 Awaiting requested review from weiji14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.x
Development

Successfully merging this pull request may close these issues.
1 participant
@seisman
0