8000 Created TaggedInputObject by leoloso · Pull Request #1226 · GatoGraphQL/GatoGraphQL · GitHub
[go: up one dir, main page]
Skip to content

Created TaggedInputObject #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Nov 14, 2021
Merged

Created TaggedInputObject #1226

merged 30 commits into from
Nov 14, 2021

Conversation

leoloso
Copy link
Collaborator
@leoloso leoloso commented Nov 14, 2021

This is a feature currently under consideration to be included in the GraphQL spec: graphql/graphql-spec#733, and already implemented for the GraphQL API for WordPress.

The Tagged Input Object introduces a form of polymorphism for inputs in GraphQL. It defines a list of named members each with an associated type (like the fields in Object types and Input Object types), where exactly one of those members must be provided as an input when resolving the query (or otherwise it returns a validation error).

The benefit is that a single mutation field can be used to tackle different use cases, so we can avoid creating a different mutation field for each use case.

For instance, the field Root.loginUser now receives a field argument credentials, which is a tagged input object allowing to provide several methods to log into the website. Currently it accepts only 1 method, via the named member website (which accepts the usernameOrEmail and password entries), and other methods can be added in the future (such as jwt and applicationPasswords):

mutation {
  loginUser(
    credentials: {
      website: {
        usernameOrEmail: "admin",
        password: "pachonga"
      },
    }
  ) {
    id
    name
  }
}

This way, loginUser can tackle all methods of logging the user, which makes the GraphQL schema leaner and more elegant (otherwise, we would need fields loginUserByWebsiteData, loginUserByJWT and loginUserByApplicationPassword).

leoloso added 30 commits November 14, 2021 11:57
@leoloso
Removed final from fn
7c2f3f4
@leoloso
Created TaggedInputObject
a0c06d3
@leoloso
Removed interface
e4bd9d6
@leoloso
Created TaggedInput for "loginUser"
bea898a
@leoloso
Renamed class
1bd1b40
@leoloso
Renamed type
7799efd
@leoloso
Added const
045c9f5
@leoloso
Created AbstractTaggedMutationResolver
45f19a4
@leoloso
Pass input values
866b3f6
@leoloso
Recreated Login as TaggedMutationResolver
423f9ea
@leoloso
Obtain the inputField from formData
d99909f
@leoloso
Renamed class
7b71b44
@leoloso
Renamed type
a02b41e
@leoloso
Register services
2ffb4d5
@leoloso
Catch exceptions
bbcecbc
@leoloso
Fixed params to Exception
c601433
@leoloso
Get tagged form data
4bf56f6
@leoloso
If validField return early
7afd587
@leoloso
Renamed class
c0a2b4f
@leoloso
Renamed class
8a02d92
@leoloso
Renamed class
f66ba33
@leoloso
Renamed getInputFieldNameMutationResolvers
3203af9
@leoloso
Added consolidated
4a8c0ab
@leoloso
Added getInputFieldMutationResolverAndFormData
506fbd1
@leoloso
Added phpdoc
103f2d7
@leoloso
Implement default getTaggedInputObjectFormData
0942954
@leoloso
Fixed PHPStan
185e167
@leoloso
Fixed cs
3b04b91
@leoloso
Added changelog
a5522d9
@leoloso
Added changelog
7cbbcf1
@leoloso leoloso merged commit 2000026 into master Nov 14, 2021
@leoloso leoloso deleted the Create-TaggedInputObject branch November 14, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leoloso
0