do not silence error logs #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires symfony/symfony#25168 to work |
The change done in FriendsOfSymfony#1797 had the disadvantage that it silenced all log entries. Using the `SHELL_VERBOSITY` env var allows to define a level for which log entries should still be shown.
ccf79a1 to
3c142db
Compare
|
This information was lost previously. |
xabbuh
added a commit
that referenced
this pull request
Nov 27, 2017
This PR was merged into the 2.3-dev branch. Discussion ---------- do not silence error logs The change done in #1797 had the disadvantage that it silenced all log entries. Using the `SHELL_VERBOSITY` env var allows to define a level for which log entries should still be shown. Commits ------- 3c142db do not silence error logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change done in #1797 had the disadvantage that it silenced all
log entries. Using the
SHELL_VERBOSITYenv var allows to define alevel for which log entries should still be shown.