Fix #1399 #1400
Merged
Fix #1399 #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ($config['view']['mime_types']['enabled'] && !method_exists(Request::class, 'getMimeTypes')) { | ||
| $container->getDefinition('fos_rest.format_negotiator')->addArgument($config['view']['mime_types']['formats']); | ||
| } |
There was a problem hiding this comment.
Are you sure that this is not needed?
There was a problem hiding this comment.
Yeah the mime types are already registered by the mime type listener in the Request and the format negotiator fetch them from the request.
There was a problem hiding this comment.
I see, so the fix basically is to call get getValue() instead of getType()?
There was a problem hiding this comment.
That's a part of the fix, we also need symfony/symfony#18255 to be merged.
There was a problem hiding this comment.
In fact this PR is useless as long as symfony/symfony#18255 is not merged.
|
symfony/symfony#18255 was merged |
|
@xabbuh thank you, I forgot this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1399
Should be merged in 2.0 (wrong target...)