when sessions are not enabled, the listener does not exist either #445
Conversation
|
@Tobion can you please check if this fixes the problem you encountered? |
|
Works 👍 |
|
great! tagged 2.2.2 with this fix |
|
things will break (explicitly) whithout this fix in projects with symfony 3.4/4.0 that do not have session handling enabled (e.g. rest apis). i think your backport did not include #439, so things will break in a bad way when using symfony 4.1 and FOSHttpCacheBundle 1.3.14 with sessions, as the session will not be saved anymore. |
|
1.3 cannot be installed on Symfony 4.x, so that's not an issue. That's why I didn't include #439 in the first place. The only open question is about Symfony 3.4. |
|
ah good. but this change is relevant for 3.4 as well. the listener expects the symfony session listener to exist. if sessions are not enabled, this is not the case, and container can't be compiled. |
|
Okay, do you want me to backport this as well? |
|
if you have the time, sure. i don't want to actively maintain version 1 anymore, but as the rest has been backported it would make sense to now also fix the regression (of not working without sessions anymore). |
|
Okay. Will do it in a day or two! 👍 |
fix problem introduced in #435, replace #444