8000 clarify user context cache impact by dbu · Pull Request #360 · FriendsOfSymfony/FOSHttpCache · GitHub
[go: up one dir, main page]

Skip to content

clarify user context cache impact #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2017
Merged

clarify user context cache impact #360

merged 1 commit into from
Dec 13, 2017

Conversation

dbu
Copy link
Contributor
@dbu dbu commented Jun 19, 2017

fix #356

some documentation to at least tell people how it is. unfortunately we can't really fix the issue.

@dbu
Copy link
Contributor Author
dbu commented Jun 19, 2017

@lolautruche would you be aware of any useful information about the topic of the HttpCache cache folder cleanup? i wonder how far we should go in here - its some pretty long boxes already, i don't want to digress from FOSHttpCache more in this doc :-)

@lolautruche
Copy link
Contributor
lolautruche commented Jun 19, 2017

@dbu Well, the only viable solution for me would be to set up a cronjob purging the cache files...

@Toflar
Copy link
Contributor
Toflar commented Sep 3, 2017

I have some ideas here @dbu. I think I can implement a decent on-a-regular-basis-cleanup-mechanism in the TaggableStore implementation 😉

@Toflar
Copy link
Contributor
Toflar commented Sep 4, 2017

A first version is implemented in #373.

@dbu dbu added this to the 2.1.0 milestone Dec 13, 2017
@ddeboer
Copy link
Member
ddeboer commented Dec 13, 2017

@dbu Is this ready to merge?

@dbu
Copy link
Contributor Author
dbu commented Dec 13, 2017

actually yes. can you check if the wording is understandable and merge/ask me for clarifications?

@Toflar did you in the end add something to the taggable store about cleaning up that we should mention in this doc? (guess we merge as is, and you can then do a separate pull request if there is anything to add)

@Toflar
Copy link
Contributor
Toflar commented Dec 13, 2017

https://github.com/Toflar/psr6-symfony-http-cache-store#pruning-expired-cache-entries

We just documented how you can configure it. So imho it's all fine here :)

@dbu
Copy link
Contributor Author
dbu commented Dec 13, 2017
8000

cool. i think that pruning does not help when you always add more variants, but then what we say in the doc here is still true.

@dbu dbu merged commit db4b527 into master Dec 13, 2017
@dbu dbu deleted the user-context-cache-size branch December 13, 2017 14:06
@Toflar
Copy link
Contributor
Toflar commented Dec 13, 2017

Yeah, I consider "always adding more variants" as being "heavy proxy work". And the basic statement of "don't use the SF HttpCache if you have heavy proxy work" is still true, even with the auto-pruning store 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increasing size of cache for Hash Response in Symfony reverse proxy
4 participants
31C6
0