8000 Update dependencies by Jeroeny · Pull Request #199 · FriendsOfBehat/SymfonyExtension · GitHub
[go: up one dir, main page]
Skip to content

Update dependencies #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update dependencies #199

wants to merge 1 commit into from

Conversation

Jeroeny
Copy link
@Jeroeny Jeroeny commented Dec 7, 2022 •
edited
Loading

symfony/proxy-manager-bridge doesn't seem to be used, and is blocking upgrade to PHP 8.2. Also it's deprecated: symfony/symfony#48484

@mpdude
Copy link
Contributor
mpdude commented Dec 9, 2022

Symfony 4.4 is not completely unsupported yet, they still have security fixes.

Is it really necessary to drop compatibility with older versions of packages, as long as we don't gain anything from it? I mean we don't have to do any extra work at the moment to keep it supported, right?

@Jeroeny
Copy link
Author
Jeroeny commented Dec 13, 2022

@mpdude Fair enough, undid that change.

@pamil
Copy link
Member
pamil commented Dec 13, 2022

I haven't worked on this extension for a while, but symfony/proxy-manager-bridge was required in the first place because Symfony failed silently to create lazy services if it's not present. There's a conditional in their code to check for its existence and I think it was a lazy Mink driver session that required it to be a lazy service indeed. We might need a test case for it though.

@Yozhef Yozhef closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeroeny @mpdude @pamil @Yozhef
0