Jonaslu fix random and update readme #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2017 08:02
The sticky load balancing pattern does not exist and gives an error when trying to run.
The underscore version that is shipped with this lib (1.4.4) does not have the method sample. Manually generate a random array index since bumping the version of underscore to current (1.8.3) breaks more stuff. Verification: * Borrow the test/basic.js and substitute roundrobin for random balancer. Access it in a browser and verify that it indeed returns random positions.
|
@jonaslu, thanks for this PR! You saved my Saturday. |
Author
|
Totally forgot about this - glad it helped! Now, if it only could reach master and be of more use... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Sorry to barge in like this, but I was on a roll fixing
things :)