Add gridpoints(::OneDGrid) and tests
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
reviewed
Jun 14, 2022
navidcy
reviewed
Jun 14, 2022
navidcy
reviewed
Jun 14, 2022
Great!
|
|
Just need a re-review to check that I have correctly bumped the patch release.. |
navidcy
approved these changes
Jun 14, 2022
|
@navidcy I have not merged this as I do not have write access. I presume you know this and will write the release etc. but I just wanted to let you know in case you were wondering why I had not already merged this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
gridpoints(::Dev, ::OneDGrid)method so that one can callx = gridpoints(x). This will make sure that the type of array is correct for thedeveitherCPUorGPU.