8000 Add support Telegram Sticker `.tgs` in Lottie Integration by dungngminh · Pull Request #659 · FlutterGen/flutter_gen · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support Telegram Sticker .tgs in Lottie Integration #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support Telegram Sticker .tgs in Lottie Integration #659

wants to merge 1 commit into from

Conversation

dungngminh
Copy link
Contributor
@dungngminh dungngminh commented Feb 14, 2025 •
edited
Loading

What does this change?

Screen.Recording.2025-02-14.at.20.50.07.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@codecov Codecov
Copy link
codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (74b1d87) to head (b7d62f0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          21       21           
  Lines         819      819           
=======================================
  Hits          799      799           
  Misses         20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dungngminh dungngminh force-pushed the main branch 3 times, most recently from da1a9cf to 5f3c681 Compare February 20, 2025 14:03
@dungngminh dungngminh requested a review from AlexV525 February 20, 2025 14:09
@dungngminh
Copy link
Contributor Author
dungngminh commented Feb 20, 2025 •
edited
Loading

@AlexV525 I noticed a problem when generating the example files because it was changing the format code, I rolled back to old example code and added changed code lines with my added assets .tgs, maybe it should be resolved on another MR instead of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasabeef wasabeef Awaiting requested review from wasabeef wasabeef is a code owner

@lcdsmao lcdsmao Awaiting requested review from lcdsmao lcdsmao is a code owner

@AlexV525 AlexV525 Awaiting requested review from AlexV525 AlexV525 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dungngminh @AlexV525
0