8000 Fix: Inconsistent `AbstractInterpContext` used in `PARTITIONNODE_OVERWRITE` and mis-port of `PARTITIONNODE_OVERWRITE` by JuliaPoo · Pull Request #41 · Fidget-Spinner/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and mis-port of PARTITIONNODE_OVERWRITE #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and mis-port of PARTITIONNODE_OVERWRITE #41

merged 2 commits into from
Aug 9, 2023

Conversation

JuliaPoo
Copy link
Collaborator
@JuliaPoo JuliaPoo commented Aug 9, 2023 •
edited
Loading

Fix three bugs:

  1. There's a mis-port of PARTITIONNODE_OVERWRITE where the child_test is supposed to use dst and not *dst
  2. The call to PARTITIONNODE_OVERWRITE requires ctx, but the stack pointer isn't updated until after propagating through the entire instruction, causing PARTITIONNODE_OVERWRITE to operate on the wrong ctx
    • Fix is to mutate ctx's stackpointer
  3. COPY should use PARTITIONNODE_OVERWRITE rather than PARTITIONNODE_SET

In addition, there's some refactor on the debugging output.

@JuliaPoo JuliaPoo changed the title Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRI… Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and typo in PARTITIONNODE_OVERWRITE Aug 9, 2023
@JuliaPoo JuliaPoo changed the title Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and typo in PARTITIONNODE_OVERWRITE Fix: Inconsistent AbstractInterpContext used in PARTITIONNODE_OVERWRITE and mis-port of PARTITIONNODE_OVERWRITE Aug 9, 2023
Fidget-Spinner
Fidget-Spinner approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner
@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Fidget-Spinner Fidget-Spinner merged commit 6ecf3d2 into partition_algo Aug 9, 2023
@Fidget-Spinner Fidget-Spinner deleted the partition_algo_jules branch August 9, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuliaPoo @Fidget-Spinner
0