append commit SHA to commit msg, only if not a part of it already. (JamesIves#236)

lycuid · JamesIves · web-flow · commit 145d802b175d · 2020-04-04T08:23:43.000-04:00
* append commit SHA to commit msg, only if not a part of it already.

* user provided commit message will remain unmodified.

* Update src/git.ts

check, if SHA exists, before appending to commit message.

Co-Authored-By: James Ives &lt;iam@jamesiv.es&gt;

* linting bug fix (from failed workflow).

Co-authored-by: James Ives &lt;iam@jamesiv.es&gt;
diff --git a/src/git.ts b/src/git.ts
@@ -100,11 +100,11 @@ export async function deploy(action: ActionInterface): Promise<void> {
   try {
     hasRequiredParameters(action)
 
-    const commitMessage = `${
-      !isNullOrUndefined(action.commitMessage)
-        ? action.commitMessage
-        : `Deploying to ${action.branch} from ${action.baseBranch}`
-    } ${process.env.GITHUB_SHA ? `@ ${process.env.GITHUB_SHA}` : ''} 🚀`
+    const commitMessage = !isNullOrUndefined(action.commitMessage)
+      ? (action.commitMessage as string)
+      : `Deploying to ${action.branch} from ${action.baseBranch} ${
+          process.env.GITHUB_SHA ? `@ ${process.env.GITHUB_SHA}` : ''
+        } 🚀`
 
     /*
         Checks to see if the remote exists prior to deploying.
