E533 [GPS] Change GPS in progress FAB to floating pill by GCyganek · Pull Request #85239 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

[GPS] Change GPS in progress FAB to floating pill#85239

Open
GCyganek wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:@GCyganek/gps/change-gps-fab-to-pill
Open

[GPS] Change GPS in progress FAB to floating pill#85239
GCyganek wants to merge 4 commits intoExpensify:mainfrom
software-mansion-labs:@GCyganek/gps/change-gps-fab-to-pill

Conversation

@GCyganek
Copy link
Contributor
@GCyganek GCyganek commented Mar 13, 2026 •
edited
Loading

Explanation of Change

Changing GPS FAB into a floating pill according to the new design

Fixed Issues

$ #85163
PROPOSAL: N/A

Tests

  1. FAB > Track distance
  2. GPS tab > tap Start to start the trip
  3. Go back to main screen
  4. Verify that there is a floating GPS pill above the bottom menu
  5. Tap the GPS pill
  6. Verify that it redirects the user to the GPS trip screen
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-03-13.at.15.49.10.mov
iOS: Native
Screen.Recording.2026-03-13.at.15.52.14.mov

@melvin-bot
Copy link
melvin-bot bot commented Mar 13, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov
Copy link
codecov bot commented Mar 13, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/styles/index.ts 47.42% <ø> (+0.51%) ⬆️
src/components/FloatingGPSButton/index.native.tsx 33.33% <20.00%> (+3.33%) ⬆️
... and 46 files with indirect coverage changes

@GCyganek GCyganek mentioned this pull request Mar 13, 2026
Open
@OSBotify
Copy link
Contributor
OSBotify commented Mar 13, 2026

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff 
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 42c51d86..597760bf 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7826,7 +7826,7 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
             confirm: 'Einstellungen öffnen',
             prompt: 'Bitte erlaube den Standortzugriff in den Einstellungen deines Geräts, um die GPS‑Streckenverfolgung zu starten.',
         },
-        gpsFloatingPillText: 'GPS-Tracking läuft...',
+        gpsFloatingPillText: 'GPS-Verfolgung läuft...',
         liveActivity: {subtitle: 'Entfernungserfassung', button: 'Fortschritt anzeigen'},
     },
     reportCardLostOrDamaged: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index f1150951..fe5847ba 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7812,7 +7812,7 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
             confirm: 'Apri impostazioni',
             prompt: 'Consenti l’accesso alla posizione nelle impostazioni del dispositivo per iniziare il tracciamento della distanza GPS.',
         },
-        gpsFloatingPillText: 'Monitoraggio GPS in corso...',
+        gpsFloatingPillText: 'Tracciamento GPS in corso...',
         liveActivity: {subtitle: 'Rilevamento distanza', button: 'Visualizza avanzamento'},
     },
     reportCardLostOrDamaged: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 096f8aa9..1dad42fe 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7725,7 +7725,7 @@ ${reportName}
             confirm: '設定を開く',
             prompt: 'GPSで距離の追跡を開始するには、端末の設定で位置情報へのアクセスを許可してください。',
         },
-        gpsFloatingPillText: 'GPS追跡を実行中...',
+        gpsFloatingPillText: 'GPS 追跡を実行中です…',
         liveActivity: {subtitle: '距離の記録', button: '進捗を表示'},
     },
     reportCardLostOrDamaged: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0f1c8db2..735516f1 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7591,7 +7591,7 @@ ${reportName}
             confirm: '打开设置',
             prompt: '请在设备设置中允许访问位置信息，以开始使用 GPS 距离跟踪。',
         },
-        gpsFloatingPillText: '正在进行 GPS 追踪...',
+        gpsFloatingPillText: '正在进行 GPS 跟踪…',
         liveActivity: {subtitle: '跟踪距离', button: '查看进度'},
     },
     reportCardLostOrDamaged: {

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@GCyganek GCyganek marked this pull request as ready for review March 13, 2026 15:39
@GCyganek GCyganek requested review from a team as code owners March 13, 2026 15:39
@GCyganek
Copy link
Contributor Author
GCyganek commented Mar 13, 2026

@codex review

@melvin-bot melvin-bot bot requested review from JmillsExpensify and huult and removed request for a team and JmillsExpensify March 13, 2026 15:39
@melvin-bot
Copy link
melvin-bot bot commented Mar 13, 2026

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 13, 2026 15:39
@huult
Copy link
Contributor
huult commented Mar 13, 2026

I can review if needed

@chatgpt-codex-connector
Copy link
chatgpt-codex-connector bot commented Mar 13, 2026

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@shawnborton
Copy link
Contributor
shawnborton commented Mar 13, 2026

The videos look good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huult huult Awaiting requested review from huult

At least 1 approving review is required to merge this pull request.

Assignees

@GCyganek GCyganek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GCyganek @OSBotify @huult @shawnborton
0