8000 [No QA] Update Workspace-Merchant-Rules.md by stephanieelliott · Pull Request #84982 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

[No QA] Update Workspace-Merchant-Rules.md#84982

Merged
RachCHopkins merged 1 commit intomainfrom
helpsite-fix-extra-line
Mar 11, 2026
Merged

[No QA] Update Workspace-Merchant-Rules.md#84982
RachCHopkins merged 1 commit intomainfrom
helpsite-fix-extra-line

Conversation

@stephanieelliott
Copy link
Contributor
@stephanieelliott stephanieelliott commented Mar 11, 2026 •
edited
Loading

Fix duplicated line in doc

@github-actions
Copy link
Contributor
github-actions bot commented Mar 11, 2026

HelpDot Documentation Review

Overall Assessment

This PR makes a small but valid cleanup to Workspace-Merchant-Rules.md by removing a duplicated FAQ heading. The file previously contained two back-to-back headings for the same question -- one title-cased (Who Can Enable Workspace Merchant Rules?) and one sentence-cased (Who can enable Workspace Merchant Rules?) -- neither of which had answer content beneath them. Removing both empty duplicate headings is the correct fix and improves the document structure.

Scores Summary

  • Readability: 9/10 - The removal of two empty, duplicated headings eliminates reader confusion. A question heading with no answer is disorienting, and having two versions of it compounds the problem. This change directly improves the reading experience.
  • AI Readiness: 9/10 - Duplicate headings are particularly problematic for AI retrieval systems, which may index both and return empty or conflicting results. Removing them improves the document's suitability for AI-assisted search and conten 8000 t extraction. The heading hierarchy in the FAQ section is now clean.
  • Style Compliance: 9/10 - The change correctly removes the inconsistency between title case and sentence case heading styles. The remaining FAQ headings in the document use sentence case consistently, which aligns with HelpDot conventions.

Key Findings

  • Positive: The PR correctly identifies and removes a genuine defect -- two empty, duplicated FAQ headings that provided no value to readers.
  • Observation (not part of this diff): The question "Who can enable Workspace Merchant Rules?" is being fully removed rather than consolidated into a single heading with an answer. If this is an intentional decision (e.g., the information is covered elsewhere in the article or is self-evident), that is reasonable. If the question is one users commonly ask, consider adding it back as a single heading with a proper answer in a follow-up PR.
  • Observation (not part of this diff): The file has a few pre-existing issues unrelated to this PR, such as a duplicated step 9 in the creation instructions (lines 35 and 39) and the first ## Who Can Enable Workspace Merchant Rules? heading at line 119 that still appears in the current main branch. These are out of scope for this review but may warrant a separate cleanup.

Recommendations

  1. No blockers -- this change is clean and ready to merge as-is.
  2. Optional follow-up: Consider whether the "Who can enable Workspace Merchant Rules?" question should be restored as a single FAQ entry with an actual answer (e.g., "Only Workspace Admins on the Control plan can enable Workspace Merchant Rules."). This information is partially covered in the YAML internalScope metadata but is not explicitly stated in the article body.
  3. Optional follow-up: Address the duplicated step 9 in the "How to create Workspace Merchant Rules" section, which appears to be a pre-existing issue in the file.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md -- 4 lines removed (two empty duplicate FAQ headings). Change is correct and improves document quality.

@github-actions github-actions bot changed the title Update Workspace-Merchant-Rules.md [No QA] Update Workspace-Merchant-Rules.md Mar 11, 2026
@OSBotify
Copy link
Contributor
OSBotify commented Mar 11, 2026

A preview of your ExpensifyHelp changes have been deployed to https://29a7f6b7.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott requested a review from a team March 11, 2026 22:28
@melvin-bot
Copy link
melvin-bot bot commented Mar 11, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot melvin-bot bot requested a review from RachCHopkins March 11, 2026 22:29
@melvin-bot
Copy link
melvin-bot bot commented Mar 11, 2026

@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 11, 2026 22:29
RachCHopkins
RachCHopkins approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor
@RachCHopkins RachCHopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RachCHopkins RachCHopkins merged commit b9bdd88 into main Mar 11, 2026
16 checks passed
@RachCHopkins RachCHopkins deleted the helpsite-fix-extra-line branch March 11, 2026 23:50
@melvin-bot melvin-bot bot added the Emergency label Mar 11, 2026
8000
@melvin-bot
Copy link
melvin-bot bot commented Mar 11, 2026

@RachCHopkins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify OSBotify mentioned this pull request Mar 12, 2026
Open
85 tasks
@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RachCHopkins RachCHopkins RachCHopkins approved these changes

Assignees

@stephanieelliott stephanieelliott

Labels

Emergency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanieelliott @OSBotify @RachCHopkins
0