8000 [NoQA] Prevent GH actions from running on auto-closed PRs by mjasikowski · Pull Request #84884 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

[NoQA] Prevent GH actions from running on auto-closed PRs#84884

Merged
MonilBhavsar merged 10 commits intomainfrom
claude-validateContributorPRs
Mar 11, 2026
Merged

[NoQA] Prevent GH actions from running on auto-closed PRs#84884
MonilBhavsar merged 10 commits intomainfrom
claude-validateContributorPRs

Conversation

@mjasikowski
Copy link
Contributor
@mjasikowski mjasikowski commented Mar 11, 2026 •
edited
Loading

Explanation of Change

New reusable workflow: contributorValidationGate.yml

  • Extracts the authorization check into a reusable workflow_call workflow that outputs IS_AUTHORIZED
  • Used by expensive pull_request_target workflows to skip CI for unauthorized contributors
    Gated workflows:
  • claude-review.yml — skips Anthropic API calls for unauthorized PRs
  • cla.yml — skips CLA check (avoids noisy comments on spam PRs)
  • authorChecklist.yml — skips PR description modification on spam PRs

Fixed Issues

Improvement for https://github.com/Expensify/Expensify/issues/609533

Tests

  1. Create a test PR from a non-org account with no linked issue in the description
  2. Verify the PR is automatically closed with a comment explaining the contribution requirements
  3. Verify the PR conversation is locked with "spam" reason
  4. Verify that Claude Code review, CLA check, and author checklist did NOT run
  5. Create a test PR from a non-org account WITH a linked issue where that account is assigned
  6. Verify the PR stays open and all CI workflows run normally
  7. Create a draft PR from a non-org account with no linked issue
  8. Verify no validation runs (drafts are skipped)
  9. Mark the draft as ready for review
  10. Verify validation runs and closes the PR

Offline tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected 8000 .
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

@mjasikowski
Add reusable contributor validation gate workflow
c1aab90 
Extracts the authorization check logic (org membership, linked issue
assignment, linked PR author/reviewer) into a reusable workflow_call
workflow that outputs IS_AUTHORIZED. This allows expensive PR workflows
to skip CI for unauthorized contributors without duplicating the logic.

Made-with: Cursor
@mjasikowski
Refactor validateContributorPR to use reusable gate workflow
62b1ea5 
Replace inline validation logic with a call to the new
contributorValidationGate reusable workflow. The close/lock/comment
logic now runs in a separate job conditioned on IS_AUTHORIZED == false.

Made-with: Cursor
@mjasikowski
Gate claude-review workflow behind contributor validation
8c0db25 
Skip AI code review (Anthropic API calls) for unauthorized contributors
by adding the reusable validation gate as a prerequisite job.

Made-with: Cursor
@mjasikowski
Gate Jest test workflow behind contributor validation
4f03d36 
Skip 8-shard Jest suite and Storybook tests for unauthorized
contributors. Uses always() + skipped check to preserve the
workflow_call path from preDeploy.yml.

Made-with: Cursor
@mjasikowski
Gate Reassure performance tests behind contributor validation
d8ec215 
Skip double npm install + perf benchmarks for unauthorized contributors.

Made-with: Cursor
@mjasikowski
Gate translation generation behind contributor validation 8000
e019584 
Skip OpenAI API calls for unauthorized contributors. Preserves
the workflow_dispatch path for manual triggers.

Made-with: Cursor
@mjasikowski
Gate HybridApp Android/iOS builds behind contributor validation
8c4ecfb 
Skip full native builds (32-vCPU Android + macOS iOS) for unauthorized
contributors. The fork comment job is left ungated since it's lightweight.

Made-with: Cursor
@mjasikowski
Gate CLA workflow behind contributor validation
c9f1388 
Skip CLA check for unauthorized contributors on pull_request_target.
The issue_comment trigger (for 'recheck' / signing) still runs ungated.

Made-with: Cursor
@mjasikowski
Gate author checklist behind contributor validation
87eb918 
Skip PR description modification for unauthorized contributors.
Preserves the 'checklist' job name required by PHP.

Made-with: Cursor
@mjasikowski
Revert gating of pull_request workflows (test, reassure, translations…
6bc591a 
…, hybridapp)

These workflows use the pull_request event which is already gated by
GitHub's fork approval setting. Only pull_request_target workflows
(claude-review, CLA, authorChecklist) need explicit gating.

Made-with: Cursor
@mjasikowski mjasikowski marked this pull request as ready for review March 11, 2026 13:12
@mjasikowski mjasikowski requested a review from a team as a code owner March 11, 2026 13:12
@mjasikowski mjasikowski requested review from MonilBhavsar and removed request for a team March 11, 2026 13:13
@melvin-bot melvin-bot bot requested a review from deetergp March 11, 2026 13:13
@melvin-bot
Copy link
melvin-bot bot commented Mar 11, 2026

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 11, 2026
View reviewed changes
Copy link
@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bc591af57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

.github/workflows/claude-review.yml

jobs:
validate:
uses: ./.github/workflows/contributorValidationGate.yml
Copy link
@chatgpt-codex-connector chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Grant issue-read scope before calling contributor gate

Calling contributorValidationGate.yml from this workflow can misclassify legitimate external contributors as unauthorized, because the gate uses github.rest.issues.get to validate linked assigned issues, but this workflow only grants contents and pull-requests permissions. With GitHub Actions permissions, omitted scopes are none, so issue lookups fail and PRs that should pass via linked-issue assignment will skip Claude review.

Useful? React with 👍 / 👎.

8000

MonilBhavsar
MonilBhavsar reviewed Mar 11, 2026
View reviewed changes
@MonilBhavsar
Copy link
Contributor
MonilBhavsar commented Mar 11, 2026 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component 8000 can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

MonilBhavsar
MonilBhavsar approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor
@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MonilBhavsar MonilBhavsar added the InternalQA This pull request required internal QA label Mar 11, 2026
@MonilBhavsar
Copy link
Contributor
MonilBhavsar commented Mar 11, 2026

Applying Internal QA label to remind us to QA

@MonilBhavsar MonilBhavsar merged commit d309679 into main Mar 11, 2026
19 of 23 checks passed
@MonilBhavsar MonilBhavsar deleted the claude-validateContributorPRs branch March 11, 2026 14:54
@OSBotify
Copy link
Contributor
OSBotify commented Mar 11, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mjasikowski
Copy link
Contributor Author
mjasikowski commented Mar 11, 2026

I'll QA this within the next hour or two

@mjasikowski
Copy link
Contributor Author
mjasikowski commented Mar 11, 2026 •
edited
Loading

QA successful!

@mjasikowski mjasikowski removed the InternalQA This pull request required internal QA label Mar 11, 2026
@OSBotify OSBotify mentioned this pull request Mar 11, 2026
Closed
@OSBotify
Copy link
Contributor
OSBotify commented Mar 11, 2026

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

@deetergp deetergp Awaiting requested review from deetergp

Assignees

@mjasikowski mjasikowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjasikowski @MonilBhavsar @OSBotify
0