[No QA] Add Travel Invoicing to updatedFeatureEnabled translations#84846
Merged
blimpich merged 2 commits intoExpensify:mainfrom Mar 11, 2026
Merged
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ All modified and coverable lines are covered by tests. |
allgandalf
commented
Mar 11, 2026
src/languages/es.ts
Outdated
Comment on lines
+6864
to
+6865
| case 'Travel Invoicing': | ||
| return `${enabled ? 'activó' : 'desactivó'} la facturación de viajes`; |
Contributor
Author
There was a problem hiding this comment.
asked for confirmation here:
https://expensify.slack.com/archives/C01GTK53T8Q/p1773216688353279
rlinoz
previously approved these changes
Mar 11, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Member
|
Do you need review here @rlinoz? |
Contributor
I think it is fine! |
blimpich
previously approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Looks good, do we need to update based on this conversation though?
Contributor
Author
Done !! |
rlinoz
approved these changes
Mar 11, 2026
blimpich
approved these changes
Mar 11, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.36-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the
'Travel Invoicing'case to theupdatedFeatureEnabledswitch in all 10 language files. Without this, when the backend sends aPOLICYCHANGELOG_UPDATE_FEATURE_ENABLEDreport action withfeatureName: "Travel Invoicing", the #admins room would fall through to the default case instead of showing the correct "enabled/disabled Travel Invoicing" message.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/609611
Tests
Note: Full end-to-end testing requires the Auth PR (Expensify/Auth#20376), which actually writes the
POLICYCHANGELOG_UPDATE_FEATURE_ENABLEDreport actions for Travel Invoicing.Offline tests
N/A — this is a display-only translation change for system messages that are created server-side.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Enabled:
Disabled: