fix: App crashes with infinite OnboardingGuard redirect loop#84699
fix: App crashes with infinite OnboardingGuard redirect loop#84699amyevans merged 4 commits intoExpensify:mainfrom
Conversation
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7969dca7ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| isSingleEntry || | ||
| needsExplanationModal || | ||
| isInvitedOrGroupMember || | ||
| isNavigatingToOnboardingFlow(action); |
There was a problem hiding this comment.
OnboardingGuard.evaluate now sets shouldSkipOnboarding to true for any action targeting OnboardingModalNavigator, which means users who have not completed onboarding can bypass the normal getOnboardingRoute() progression logic on NAVIGATE/PUSH deep-link actions and open later onboarding routes directly. That progression logic is where we enforce step selection from onboardingInitialPath and qualifier-specific routing, so this change can send users into out-of-sequence onboarding states; the bypass should be limited to the REPLACE loop scenario instead of all onboarding-target actions.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@mkhutornyi I think that makes sense. I updated.
There was a problem hiding this comment.
Damn, that's an unfortunate crash. Let's get this fixed ASAP 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-03-10.at.4.50.34.pm.mov |
|
@nkdengineer your screenshots are not complete. Use any temp email service for work email |
|
@mkhutornyi We can also reproduce the bug in the validate step and going back. No need to complete the verify step. |
ok please update tests step with yours. |
|
@amyevans as you reproduced crash in customer's account, can you please test that account against this branch? |
I updated. |
|
failing test related to GH 
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Tested on the ad hoc, I think it looks good, caveat though that behavior is a little bit funky when support-logging in on an adhoc, so I will verify once the PR hits staging as well. |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.36-0 🚀
|
|
Supportaled into the customer's account on Staging and confirmed the crash is gone 💪 |
|
Ugh actually I take that back... I had an existing staging NewDot window open and that one crashed: 
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
Explanation of Change
fix: App crashes with infinite OnboardingGuard redirect loop
Fixed Issues
$ #83212
PROPOSAL: #83212 (comment)
Tests
Add emailbuttonOffline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-10.at.15.27.51.mov
Android: mWeb Chrome
Screen.Recording.2026-03-10.at.14.52.36.mov
iOS: Native
Screen.Recording.2026-03-10.at.15.29.23.mov
iOS: mWeb Safari
Screen.Recording.2026-03-10.at.15.28.49.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-10.at.14.44.39.mov