Feat: Add 'Move to report' in the 'More' menu of a one-expense report#84512
Feat: Add 'Move to report' in the 'More' menu of a one-expense report#84512aldo-expensify merged 9 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| options.push(CONST.REPORT.TRANSACTION_SECONDARY_ACTIONS.DUPLICATE); | ||
| } | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Let's add tests for this case
There was a problem hiding this comment.
Got it, added the test case
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b06c1a6e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/components/MoneyReportHeader.tsx
Outdated
| if (transactions.length !== 1) { | ||
| return false; |
There was a problem hiding this comment.
Base single-expense visibility on non-deleted transactions
canMoveSingleExpense checks transactions.length, but this header builds secondaryActions from nonPendingDeleteTransactions (the visible list). When a report has one visible expense plus another expense pending deletion, getSecondaryReportActions can include MOVE_EXPENSE while this guard returns false, so the new menu item is incorrectly hidden until the pending delete finishes. This regresses the intended “one-expense report” behavior for in-flight delete states.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@ZhenjaHorbach When there is a pending delete expense, do you think we should include the I guess we should, to match the other single expense secondary action button like MOVE_EXPENSE option? If so, we can check it with nonPendingDeleteTransactions instead of transactionsSplit, Merge and Duplicate expense. Updated!
There was a problem hiding this comment.
Agreed product change. 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-03-10.12.45.13.movAndroid: mWeb Chrome2026-03-10.12.42.52.moviOS: HybridApp2026-03-10.12.45.13.moviOS: mWeb Safari2026-03-10.12.42.52.movMacOS: Chrome / Safari2026-03-10.12.37.51.mov |
|
@nyomanjyotisa please resolve conflicts 🙇 |
|
@aldo-expensify conflict resolved 👍 |
|
🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.36-0 🚀
|
|
Deploy Blocker #84976 was identified to be related to this PR. |
|
Deploy Blocker #85012 was identified to be related to this PR. |
|
Deploy Blocker #85014 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
Explanation of Change
Add "Move to report" in the secondary actions when there's exactly one transaction that can be moved
Fixed Issues
$ #83884
PROPOSAL: #83884 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4