8000 [No QA] Move UK-and-EU-Expensify-Card.md to hidden folder by stephanieelliott · Pull Request #84469 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

[No QA] Move UK-and-EU-Expensify-Card.md to hidden folder #84469

Merged
joekaufmanexpensify merged 4 commits intomainfrom
helpsite-expensify-card-uk-hide
Mar 9, 2026
Merged

[No QA] Move UK-and-EU-Expensify-Card.md to hidden folder #84469
joekaufmanexpensify merged 4 commits intomainfrom
helpsite-expensify-card-uk-hide

Conversation

@stephanieelliott
Copy link
Contributor
@stephanieelliott stephanieelliott commented Mar 6, 2026 •
edited by github-actions bot
Loading

Slack convo: https://expensify.slack.com/archives/C02QSAC6BJ8/p1772837599247959?thread_ts=1772561578.595719&cid=C02QSAC6BJ8

Original PR: #84319

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videosundefined

@github-actions
Copy link
Contributor
github-actions bot commented Mar 6, 2026

$(cat <<'EOF'

HelpDot Documentation Review

This PR deletes docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md (110 lines removed, 0 lines added).

Observations

Since the diff contains only deleted lines and no added or modified content, there are no inline comment violations to flag. However, there are two structural concerns worth noting:

1. File is not actually moved to the Hidden folder in this PR
The PR title says "Move UK-and-EU-Expensify-Card.md to hidden folder," but the file is only being deleted here -- it is not being added to the docs/Hidden/ directory. If the intent is to move it, the corresponding addition to docs/Hidden/ appears to be missing from this PR. Please confirm whether the move to docs/Hidden/ is handled in a separate PR or if this is an oversight.

2. No redirect configured for the deleted URL
The file docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md is not present in docs/redirects.csv. If this article was previously published and accessible at https://help.expensify.com/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card, deleting it without adding a redirect entry will produce 404 errors for any existing bookmarks, search engine results, or external links. Consider adding a redirect to redirects.csv pointing the old path to an appropriate destination.

3. No broken internal links
No other documentation files in the repository reference this deleted file, so there are no broken internal link concerns.

Automated HelpDot documentation review
EOF
)

@github-actions
Copy link
Contributor
github-actions bot commented Mar 6, 2026

HelpDot Documentation Review

Overall Assessment

This PR deletes the file docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md (110 lines removed, 0 lines added). The PR title states the file is being "moved to a hidden folder," but the PR itself contains only the deletion -- there is no corresponding addition of the file to any hidden or underscore-prefixed directory within this changeset.

This raises an important question: where is the "move" portion of this change? In Jekyll (which powers these docs), directories prefixed with an underscore (e.g., _hidden/) are excluded from site generation. However, this PR does not create any such directory or place the file there. The original PR #84319 that created this file was merged the same day, and this PR appears to be an immediate reversal of that addition.

Key concern: If the intent is truly to move (not delete) the file, the "add" side of the move is missing from this PR. If the intent is to fully remove the article from the public help site, the PR title is misleading and should be updated to reflect a deletion rather than a move.

Scores Summary

Because this PR contains only a file deletion with no new or modified documentation content to evaluate, traditional documentation quality scoring is not directly applicable. However, I am scoring based on the process and completeness of the change itself:

  • Readability: N/A - No new or modified content to assess. The deleted file's content is not in scope for review.
  • AI Readiness: N/A - No new or modified metadata or headings to assess.
  • Style Compliance: 4/10 - The PR title ("Move ... to hidden folder") does not accurately describe the change (a deletion with no corresponding addition). There is no redirect entry in redirects.csv for the removed URL path, which could result in 404 errors for anyone who bookmarked or linked to this article externally.

Key Findings

  • Missing "move" destination: The PR title says "move to hidden folder," but only the deletion half is present. No file is added to any hidden or underscore-prefixed directory. If this is intentional (i.e., the move will happen in a separate PR or through another mechanism), it should be documented in the PR description.
  • No redirect configured: The file docs/redirects.csv does not contain an entry for the UK-and-EU-Expensify-Card path. If this article was ever linked to externally (e.g., shared with UK/EU customers, linked from support tickets, or indexed by search engines), removing it without a redirect will produce a broken link / 404 page.
  • No broken internal links: A search of all documentation files confirms that no other HelpDot article links to UK-and-EU-Expensify-Card.md, so there is no risk of broken cross-references within the docs site.
  • Original PR context: PR [No QA] [HOLD] [No QA] Create UK-and-EU-Expensify-Card.md‎ #84319 (which created this file) was merged earlier the same day. This PR appears to be a rapid course correction, likely based on the Slack conversation referenced in the description.
  • The deleted content itself was well-structured: For reference, the article that is being removed had proper YAML frontmatter with a well-formed internalScope, clear headings, an FAQ section, and links to related resources. If this content is being preserved elsewhere (as the title implies), that is positive.

Recommendations

  1. Clarify the PR title and description: If this is a pure deletion, update the title to "Delete UK-and-EU-Expensify-Card.md" rather than "Move." If the file is genuinely being moved, include the destination file addition in this same PR so reviewers can verify the move is complete.
  2. Add a redirect: Consider adding an entry to docs/redirects.csv that redirects the old URL path to an appropriate alternative page (e.g., the general Expensify Card setup page or the wallet-and-payments hub). This protects against external broken links.
  3. Document the rationale: The PR description references a Slack conversation but does not summarize why the article is being removed/hidden. A brief explanation in the PR body would help future contributors understand the decision.

Files Reviewed

File Status Notes
docs/articles/new-expensify/expensify-card/UK-and-EU-Expensify-Card.md DELETED (110 lines) Full file removal. No corresponding addition found in this PR. No redirect configured. No other docs reference this file.

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 6, 2026
View reviewed changes
Copy link
@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b966520469

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott
Create UK-and-EU-Expensify-Card.md
cf7a6ad 
Add file in hidden folder
@stephanieelliott stephanieelliott requested a review from a team as a code owner March 6, 2026 23:55
@melvin-bot melvin-bot bot requested a review from inimaga March 6, 2026 23:56
@melvin-bot
Copy link
melvin-bot bot commented Mar 6, 2026

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 6, 2026 23:56
@stephanieelliott stephanieelliott requested review from joekaufmanexpensify and removed request for inimaga March 6, 2026 23:59
@github-actions github-actions bot changed the title Move UK-and-EU-Expensify-Card.md to hidden folder [No QA] Move UK-and-EU-Expensify-Card.md to hidden folder Mar 7, 2026
@OSBotify
Copy link
Contributor
OSBotify commented Mar 7, 2026 •
edited
Loading

A preview of your ExpensifyHelp changes have been deployed to https://8564c2c4.helpdot.pages.dev ⚡️

Updated articles:

joekaufmanexpensify
joekaufmanexpensify previously approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor
@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joekaufmanexpensify
Copy link
Contributor
joekaufmanexpensify commented Mar 9, 2026

Looks good, just has conflicts to resolve @stephanieelliott

@stephanieelliott
Copy link
Contributor Author
stephanieelliott commented Mar 9, 2026

@MelvinBot are the remote build tests required on this PR? Since this PR only edits .md files under /docs, shouldn't these tests be skipped?

@MelvinBot
Copy link
Contributor
MelvinBot commented Mar 9, 2026

The remote build workflows (remote-build-android.yml and remote-build-ios.yml) both have paths-ignore filters that include docs/**:

paths-ignore: ['docs/**', 'contributingGuides/**', 'help/**', '.github/**', 'scripts/**', 'tests/**']

Since this PR only changes docs/Hidden/UK-and-EU-Expensify-Card.md and docs/redirects.csv — both under docs/ — these workflows should be skipped by GitHub Actions and are not required for this PR.

The builds showing as "pending" are likely stuck because the workflow was correctly skipped (due to path filters), but GitHub's required status checks are still waiting for a result that will never arrive. This is a known GitHub limitation with path-filtered workflows that are also set as required checks.

A repo admin should be able to merge the PR despite the pending checks, or the checks may need to be manually dismissed.

@joekaufmanexpensify joekaufmanexpensify self-requested a review March 9, 2026 20:06
joekaufmanexpensify
joekaufmanexpensify approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor
@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joekaufmanexpensify joekaufmanexpensify merged commit a716809 into main Mar 9, 2026
20 checks passed
@joekaufmanexpensify joekaufmanexpensify deleted the helpsite-expensify-card-uk-hide branch March 9, 2026 20:06
@OSBotify OSBotify mentioned this pull request Mar 9, 2026
Closed
75 tasks
@OSBotify
Copy link
Contributor
OSBotify commented Mar 9, 2026

🚀 Deployed to staging by https://github.com/joekaufmanexpensify in version: 9.3.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor
OSBotify commented Mar 10, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions github-actions bot mentioned this pull request Mar 11, 2026
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@joekaufmanexpensify joekaufmanexpensify joekaufmanexpensify approved these changes

Assignees

@stephanieelliott stephanieelliott

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephanieelliott @OSBotify @joekaufmanexpensify @MelvinBot
0