8000 Defer startup imports by elirangoshen · Pull Request #84390 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

Defer startup imports#84390

Merged
Julesssss merged 9 commits intoExpensify:mainfrom
callstack-internal:eliran/sentry-defer-imports
Mar 11, 2026
Merged

Defer startup imports#84390
Julesssss merged 9 commits intoExpensify:mainfrom
callstack-internal:eliran/sentry-defer-imports

Conversation

@elirangoshen
Copy link
Contributor
@elirangoshen elirangoshen commented Mar 6, 2026 •
edited by Julesssss
Loading

Explanation of Change

Defers loading of four non-critical modules — UnreadIndicatorUpdater, replaceOptimisticReportWithActualReport, subscribeToPushNotifications, and registerPaginationConfig — until after the splash screen hides,
instead of importing them statically at module load time. This is done via direct dynamic import() calls inside a useEffect in SplashScreenStateContext, triggered when splashScreenState transitions to HIDDEN.

Both UnreadIndicatorUpdater and replaceOptimisticReportWithActualReport register heavy Onyx.connectWithoutView subscriptions with waitForCollectionCallback: true on large collections (```
COLLECTION.REPORT,
COLLECTION.REPORT_ACTIONS, COLLECTION.REPORT_DRAFT_COMMENT
). When imported statically, these subscriptions compete for I/O with the critical-path Onyx reads that gate the splash screen (
SESSION,
IS_CHECKING_PUBLIC_ROOM, preferredLocale). Deferring them removes that contention and allows startup reads to complete faster.

This is safe because UnreadIndicatorUpdater and replaceOptimisticReportWithActualReport use waitForCollectionCallback: true, meaning they receive a full snapshot of all current data when they first subscribe —
no events or updates are missed regardless of when they load.

Fixed Issues

$#84624

Tests

  1. Open the app from a cold start on iOS and Android
  2. Verify the splash screen hides normally with no delay or regression
  3. Verify the unread badge count on the app icon updates correctly after the app is open
  4. Create a new DM, send a message, and verify the report loads correctly (validates replaceOptimisticReportWithActualReport still works)
  5. Verify that no errors appear in the JS console

Offline tests

  1. Enable airplane mode and cold start the app
  2. Verify the splash screen still hides and cached data renders correctly
  3. Re-enable network and verify unread counts and report data update normally

QA Steps

  1. Cold start the app on iOS and Android
  2. Verify the splash screen hides at a normal speed with no regression
  3. Verify unread badge count on the app icon is correct
  4. Create a new DM with another user and confirm the chat opens and messages send correctly
  5. Verify no JS console errors are present during or after startup

QA team, could you also please re-run the deep linking test case after the app has been killed. Thanks!

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, co 8000 de blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

elirangoshen and others added 3 commits March 6, 2026 10:02
@elirangoshen @claude
Defer non-critical Onyx subscriptions until after splash hides
2c45014 
UnreadIndicatorUpdater and replaceOptimisticReportWithActualReport both
register heavy Onyx collection subscriptions (waitForCollectionCallback: true
on COLLECTION.REPORT and COLLECTION.REPORT_ACTIONS) at module import time,
competing with critical-path startup reads. Deferring them via
requestAnimationFrame after the splash hides removes this I/O contention
without missing any data, since both modules receive a full collection
snapshot on first subscription.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@elirangoshen
Merge branch 'main' into eliran/sentry-defer-imports
3dcd9ee
@elirangoshen
composition fix
3b615f3
adhorodyski
adhorodyski reviewed Mar 9, 2026
View reviewed changes
@elirangoshen elirangoshen marked this pull request as ready for review March 10, 2026 13:30
@elirangoshen elirangoshen requested review from a team as code owners March 10, 2026 13:30
@melvin-bot melvin-bot bot requested review from arosiclair and heyjennahay and removed request for a team March 10, 2026 13:30
@melvin-bot
Copy link
melvin-bot bot commented Mar 10, 2026

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov
Copy link
codecov bot commented Mar 10, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great j 10000 ob!

Files with missing lines Coverage Δ
src/Expensify.tsx 88.79% <ø> (ø)
src/SplashScreenStateContext.tsx 92.30% <100.00%> (+8.97%) ⬆️
src/setup/index.ts 100.00% <100.00%> (ø)
... and 241 files with indirect coverage changes

@elirangoshen elirangoshen changed the title [No-QA] Defer startup imports Defer startup imports Mar 10, 2026
github-actions[bot]
github-actions bot reviewed Mar 10, 2026
View reviewed changes
github-actions[bot]
github-actions bot reviewed Mar 10, 2026
View reviewed changes
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 10, 2026
View reviewed changes
Copy link
@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c05c78bc2e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@arosiclair arosiclair requested a review from Julesssss March 10, 2026 15:18
@elirangoshen elirangoshen mentioned this pull request Mar 10, 2026
Open
@elirangoshen elirangoshen mentioned this pull request Mar 10, 2026
Open
Julesssss
Julesssss reviewed Mar 10, 2026
View reviewed changes
Copy link
Contributor
@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Could you just run some before/after performance timing so we have some metrics. Thanks

roryabraham
roryabraham previously approved these changes Mar 10, 2026
View reviewed changes
Copy link
Contributor
@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is NAB/could be a follow-up. Code changes look good. I think useEffect ended up simpler than using a headless component and React.lazy

src/Expensify.tsx Outdated
import PushNotification from './libs/Notification/PushNotification';
// Must be imported statically (outside React lifecycle) so push notification handlers
// are registered before any push arrives, including Android headless/background wake-ups.
import './libs/Notification/PushNotification/subscribeToPushNotifications';
Copy link
Contributor
@roryabraham roryabraham Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion/potential follow-up:

  • move this to the setup lib to clarify its independence from React lifecycles
  • wrap a dynamic import in requestIdleCallback to defer it, see if that helps.

Copy link
Contributor Author
@elirangoshen elirangoshen Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Ill use requestIdleCallback it wont be risky for the subscribeToPushNotifications to not trigger on time similar to previous scenario ? as requestIdleCallback defers execution until the browser/JS thread is idle - and maybe notification can get before that ?

Copy link
Contributor Author
@elirangoshen elirangoshen Mar 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so when moving it to setup I got very nice improvement of 750ms from before the changes which is around 5% faster :) so I pushed it now @roryabraham

arosiclair
arosiclair previously approved these changes Mar 11, 2026
View reviewed changes
@elirangoshen
Copy link
Contributor Author
elirangoshen commented Mar 11, 2026

Looking good! Could you just run some before/after performance timing so we have some metrics. Thanks

Before median value of 5 runs of manual start up span was 13370ms
after median value 5 runs was 13317ms.

while its not big change It still better and also better refactor.

@elirangoshen elirangoshen dismissed stale reviews from arosiclair and roryabraham via 2202b69 March 11, 2026 15:10
@Julesssss
Copy link
Contributor
Julesssss commented Mar 11, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss Julesssss merged commit c75dafb into Expensify:main Mar 11, 2026
32 of 34 checks passed
@github-actions
Copy link
Contributor
github-actions bot commented Mar 11, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions github-actions bot mentioned this pull request Mar 11, 2026
Closed
@github-actions
Copy link
Contributor
github-actions bot commented Mar 11, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84390.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c75dafb-3d8daef-099d81665ef12600a5f8ac96537ab5e10588fd80/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c75dafb-3d8daef-ae8b58dc5f8cb54e133be47276fdc45cb2f262bb/index.html
Android iOS
Web 🕸️
https://84390.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 12, 2026
Open
85 tasks
@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@Julesssss Julesssss Julesssss approved these changes

@arosiclair arosiclair arosiclair left review comments

@roryabraham roryabraham roryabraham left review comments

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

@adhorodyski adhorodyski Awaiting requested review from adhorodyski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elirangoshen @Julesssss @OSBotify @arosiclair @adhorodyski @roryabraham
0