8000 Enable platform tree shaking in hermes bundle by rinej · Pull Request #83359 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

Enable platform tree shaking in hermes bundle#83359

Merged
Julesssss merged 3 commits intoExpensify:mainfrom
callstack-internal:cleanup-platform-specifics-from-hermes-build
Mar 10, 2026
Merged

Enable platform tree shaking in hermes bundle#83359
Julesssss merged 3 commits intoExpensify:mainfrom
callstack-internal:cleanup-platform-specifics-from-hermes-build

Conversation

@rinej
Copy link
Contributor
@rinej rinej commented Feb 24, 2026 •
edited
Loading

Explanation of Change

Summary

  • Minimal config changes to enable platform tree shaking in the Hermes bytecode bundle, by using experimentalImportSupport and disableImportExportTransform flag.
  • Added a babel-jest override so Jest tests continue to work (Jest runs in Node.js without Metro's transform)

What is NOT changed (vs reverted PR 80110)

  • Expo Metro config stays untouched (getExpoDefaultConfig, expoConfig, mergeConfig), as it is used actively in the app
  • Android entry point stays unchanged

Fixed Issues

$ #80500
PROPOSAL:

Tests

Offline tests

QA Steps

  • Build and test on iOS - no native share, PDF, or tag import regressions
  • Build and test on Android - app launches and functions normally

Make sure that flows from those tickets are working properly:
Native share - Unexpected error appears in chat when sharing an image
Scan-PDF receipt is not displayed when opened for the first time
Tags - Import multi-level tags to workspace is failed

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rinej rinej mentioned this pull request Feb 25, 2026
Open
@github-actions
Copy link
Contributor
github-actions bot commented Feb 27, 2026

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@codecov
8000 Copy link
codecov bot commented Feb 27, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 174 files with indirect coverage changes

@github-actions
Copy link
Contributor
github-actions bot commented Mar 9, 2026

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor
github-actions bot commented Mar 9, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83359.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d8570ac-58fa64b-d07163791e5449b8a959f7768cad55c433cd61d2/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d8570ac-58fa64b-00db579a701a353e9f04636b8124915180890a90/index.html
Android iOS
Web 🕸️
https://83359.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@Julesssss Julesssss self-requested a review March 9, 2026 18:15
@rinej rinej marked this pull request as ready for review March 10, 2026 11:43
@rinej rinej requested a review from a team as a code owner March 10, 2026 11:43
@melvin-bot melvin-bot bot requested review from dukenv0307 and roryabraham March 10, 2026 11:43
@rinej
Copy link
Contributor Author
rinej commented Mar 10, 2026

I tested the build on Android - it looks fine. QAs will need to test the iOS as I cannot install the adhoc build.
@Julesssss It is ready for review

@melvin-bot melvin-bot bot removed the request for review from a team March 10, 2026 11:43
@melvin-bot
Copy link
melvin-bot bot commented Mar 10, 2026

@dukenv0307 @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss Julesssss changed the title Enable platform tree shaking in hermes bundle [NO QA] Enable platform tree shaking in hermes bundle Mar 10, 2026
@Julesssss Julesssss changed the title [NO QA] Enable platform tree shaking in hermes bundle Enable platform tree shaking in hermes bundle Mar 10, 2026
@Julesssss
Copy link
Contributor
Julesssss commented Mar 10, 2026

I tested the build on Android - it looks fine

iOS looks good to me! Tested the listed flows without issue.

@Julesssss
Copy link
Contributor
Julesssss commented Mar 10, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss Julesssss merged commit 85b4a45 into Expensify:main Mar 10, 2026
32 of 33 checks passed
@github-actions
Copy link
Contributor
github-actions bot commented Mar 10, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@Julesssss
Copy link
Contributor
Julesssss commented Mar 10, 2026

Ah @rinej would you mind sharing the before/after bundle size, for reference in the future? Thanks. No need to block merging but it would be good to know.

@github-actions
Copy link
Contributor
github-actions bot commented Mar 10, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83359.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-85b4a45-d04040c-3179a204977811bd5dc85d72a5d36011cde53166/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-85b4a45-d04040c-4cd3ca56bb0abdd91b5c29e363c06f85a5667a21/index.html
Android iOS
Web 🕸️
https://83359.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor
OSBotify commented Mar 10, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 11, 2026
Closed
@OSBotify
Copy link
Contributor
OSBotify commented Mar 11, 2026

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim mitarachim mentioned this pull request Mar 11, 2026
4D24
Closed
7 tasks
@mitarachim
Copy link
mitarachim commented Mar 11, 2026 •
edited
Loading

@rinej This PR is failing because of a regression issue #84969 and issue #85018

The issue #84969 is reproducible in: Android

Bug7100354_1773260886651.Screen_Recording_20260312_042709_Expensify.mp4

The issue #85018 is reproducible in: Android and iOS

Bug7100361_1773261296832.Screen_Recording_20260312_043339_Expensify.mp4

@mitarachim mitarachim mentioned this pull request Mar 12, 2026
Closed
7 tasks
@rinej
Copy link
Contributor Author
rinej commented Mar 12, 2026

@Julesssss It looks like the Metro config introduced similar issues as before. Enabling experimental tree shaking seems to be the main reason for the regression, rather than the Expo Metro config cleanup as we initially expected

With that in mind, it looks like we’re not able to successfully enable platform shaking right now

Would you mind going with a revert?

@luacmartins luacmartins mentioned this pull request Mar 12, 2026
Merged
@luacmartins
Copy link
Contributor
luacmartins commented Mar 12, 2026 •
edited
Loading

Revert here #85099

@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these 4D1C changes

@dukenv0307 dukenv0307 Awaiting requested review from dukenv0307

@roryabraham roryabraham Awaiting requested review from roryabraham

Assignees

@rinej rinej

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rinej @Julesssss @OSBotify @mitarachim @luacmartins
0