8000 fix: preview is displayed cutted off when adding expense by daledah · Pull Request #78971 · Expensify/App · GitHub
[go: up one dir, main page]
Skip to content

fix: preview is displayed cutted off when adding expense#78971

Merged
srikarparsi merged 8 commits intoExpensify:mainfrom
daledah:fix/78603
Mar 10, 2026
Merged

fix: preview is displayed cutted off when adding expense#78971
srikarparsi merged 8 commits intoExpensify:mainfrom
daledah:fix/78603

Conversation

@daledah
Copy link
Contributor
@daledah daledah commented Jan 7, 2026 •
edited
Loading

Explanation of Change

Fixed Issues

$ #78603
PROPOSAL: #78603 (comment)

Tests

Prerequisite: Account has at least one workspace.

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Create two manual expenses.
  4. On report preview, scroll to the right to the second expense preview.
  5. Open the report.
  6. Select both expenses.
  7. Tap on dropdown menu > "Move Expenses" > "Create Report"
  8. Return to chat.
  9. On the now empty report, tap on "Add Expense" > "Create Expense"
  10. Create a manual expense.
  11. Verify that: Preview of expense added to empty report, should be completelly visible.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies th 8000 e UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
a.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios.mov
MacOS: Chrome / Safari
web.mov

@codecov
Copy link
codecov bot commented Jan 7, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ReportPreview/MoneyRequestReportPreviewContent.tsx 61.17% <62.50%> (+0.03%) ⬆️
... and 15 files with indirect coverage changes

@daledah daledah marked this pull request as ready for review January 7, 2026 18:20
@daledah daledah requested review from a team as code owners January 7, 2026 18:20
@melvin-bot melvin-bot bot requested a review from abzokhattab January 7, 2026 18:20
@melvin-bot
Copy link
melvin-bot bot commented Jan 7, 2026

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team January 7, 2026 18:20
@abzokhattab
Copy link
Contributor
abzokhattab commented Jan 8, 2026 •
edited
Loading

just found that @linhvovan29546 raised an upstream PR facebook/react-native#54871 for an issue that is similar to this one...

@linhvovan29546 can you please let us know if it will also fix the current issue?

Sorry, something went wrong.

@linhvovan29546
Copy link
Contributor
linhvovan29546 commented Jan 8, 2026

I did a quick review and I don't think it's the same issue

@daledah
Copy link
Contributor Author
daledah commented Jan 14, 2026

@abzokhattab It seems I can't reproduce this bug on the main branch. Could you please check it again?

@abzokhattab abzokhattab mentioned this pull request Jan 17, 2026
Open
7 tasks
JmillsExpensify
JmillsExpensify reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor
@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a design improvement. No product review required.

@daledah
Copy link
Contributor Author
daledah commented Feb 24, 2026

@abzokhattab i updated this PR to use the new solution. Could you please check again?

@abzokhattab
Copy link
Contributor
abzokhattab commented Feb 28, 2026

@daledah The mweb-ios video you provided doesn't follow the test steps ... when I tried it locally, it appears that the bugs still exists

Screen.Recording.2026-02-28.at.02.35.16.mov
Screenshot 2026-02-28 at 02 41 01

@abzokhattab
Copy link
Contributor
abzokhattab commented Feb 28, 2026 •
edited
Loading

The root cause i found was that the original scrollToOffset({offset: 0}) tells FlashList "scroll to position 0" — but it doesn't clear FlashList's internal layout state. On iOS mweb specifically, FlashList's underlying RecyclerListView caches the layout positions and scroll context from the previous populated state (when there were 2 items, and the user had scrolled right .When new data arrives (0→1 item), RecyclerListView reuses that stale layout to determine which items fall within the visible window. Since the cached scroll offset puts the viewport beyond where the single new item lives, RecyclerListView decides there's nothing to render ... and the scrollToOffset call can't fix it because it arrives after RecyclerListView has already made that decision

I found this solution to be working ... but can you please check it in all platforms and see if it causes any regressions or performance issues ... if you have other solutions we can also discuss them

    const prevTransactionCountForScroll = useRef(carouselTransactions.length);
    const [carouselKey, setCarouselKey] = useState(0);
    useEffect(() => {
        if (carouselTransactions.length > 0 && prevTransactionCountForScroll.current === 0) {
            setCurrentIndex(0);
            setOptimisticIndex(undefined);
            setCarouselKey((prev) => prev + 1);
        }
        prevTransactionCountForScroll.current = carouselTransactions.length;
    }, [carouselTransactions.length]);

@daledah
Copy link
Contributor Author
daledah commented Mar 2, 2026

thanks @abzokhattab, i tested well and updated. Please check again

abzokhattab
abzokhattab reviewed Mar 3, 2026
View reviewed changes
src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
// undefined makes arrow buttons react on currentIndex changes when scrolling manually
const [optimisticIndex, setOptimisticIndex] = useState<number | undefined>(undefined);
const carouselRef = useRef<FlashListRef<Transaction> | null>(null);
const prevTransactionCountForScroll = useRef(carouselTransactions.length);
Copy link
Contributor
@abzokhattab abzokhattab Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see we have this ref prevCarouselTransactionLength that does the same ... can it be used instead?

Copy link
Contributor Author
@daledah daledah Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abzokhattab i think they serve different purposes. prevCarouselTransactionLength starts at 0 and updates in the cleanup of its effect, while prevTransactionCountForScroll starts at carouselTransactions.length and updates at the end of its effect.

@abzokhattab
Copy link
Contributor
abzokhattab commented Mar 7, 2026 •
edited
Loading

@daledah can you please remerge from main .. i see afailing eslint check

lets tackle it if its still not fixed after the merge ... i see the fix is simple

@daledah
Copy link
Contributor Author
daledah commented Mar 9, 2026

@abzokhattab all looks good now

@abzokhattab
Copy link
Contributor
abzokhattab commented Mar 10, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-02-28.at.02.01.59.mov
Android: mWeb Chrome
Screen.Recording.2026-02-28.at.03.03.07.mov
iOS: HybridApp
Screen.Recording.2026-02-28.at.02.05.42.mov
iOS: mWeb Safari
Screen.Recording.2026-02-28.at.02.54.22.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-28.at.03.04.36.mov

@melvin-bot melvin-bot bot requested a review from srikarparsi March 10, 2026 19:56
@srikarparsi srikarparsi merged commit a270cc3 into Expensify:main Mar 10, 2026
30 checks passed
@github-actions
Copy link
Contributor
github-actions bot commented Mar 10, 2026

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.
BEA4

@github-actions
Copy link
Contributor
github-actions bot commented Mar 10, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78971.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a270cc3-d04040c-3179a204977811bd5dc85d72a5d36011cde53166/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a270cc3-d04040c-4cd3ca56bb0abdd91b5c29e363c06f85a5667a21/index.html
Android iOS
Web 🕸️
https://78971.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor
OSBotify commented Mar 10, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 11, 2026
Closed
@OSBotify
Copy link
Contributor
OSBotify commented Mar 11, 2026

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor
OSBotify commented Mar 12, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmillsExpensify JmillsExpensify JmillsExpensify left review comments

@srikarparsi srikarparsi srikarparsi approved these changes

+1 more reviewer

@abzokhattab abzokhattab abzokhattab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daledah daledah

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daledah @abzokhattab @linhvovan29546 @OSBotify @JmillsExpensify @srikarparsi
0