Set Buffer byte order before reading shape type.#121
Merged
stolstov merged 1 commit intoEsri:masterfrom Aug 23, 2016
kjkrum:shape-type-byte-order
Merged
Set Buffer byte order before reading shape type.#121stolstov merged 1 commit intoEsri:masterfrom kjkrum:shape-type-byte-order
stolstov merged 1 commit intoEsri:masterfrom
kjkrum:shape-type-byte-order
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the byte order of
shapeBufferto little endian before reading the shape type. This change addresses the aspect of #118 that is strictly a bug as opposed to a design issue.Reference: ESRI Shapefile Technical Description. See shape record content tables beginning on page 6.