10000 Release 1.7.0: Only crash in debug mode, if HTTPClient was not shutdown (#478) · EdadealMobileDevelopment/async-http-client · GitHub
[go: up one dir, main page]
Skip to content

1.7.0

  • 1.7.0
  • ec2e080

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
  • Compare
    Choose a tag to compare
1.7.0: Only crash in debug mode, if HTTPClient was not shutdown (#478)
  • 1.7.0
  • ec2e080
  • Compare
    Choose a tag to compare

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
@fabianfett fabianfett tagged this 17 Nov 13:22 
### Motivation

Generally we want to inform users that they need to shutdown their HTTPClient. Until `1.6.0` we did this with an assert in HTTPClient's deinit. With `1.6.0` this behavior was raised to a precondition. Because of this adopters might suddenly crash in production where they didn't before.

### Changes

- This pr reverts the current behavior back to something pre `1.6.0`

### Result

- HTTPClient doesn't crash in production anymore.
Assets 2
Loading
0