本番モードのmonolog 調整 #5322
Merged
本番モードのmonolog 調整 #5322
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.1 #5322 +/- ##
============================================
+ Coverage 68.42% 68.54% +0.11%
Complexity 6159 6159
============================================
Files 463 463
Lines 25280 25285 +5
============================================
+ Hits 17298 17331 +33
+ Misses 7982 7954 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8000
app/config/eccube/packages/prod/monolog.yml
Outdated
| @@ -10,7 +16,7 @@ monolog: | |||
| max_files: 60 | |||
| path: '%kernel.logs_dir%/%kernel.environment%/site.log' | |||
| formatter: eccube.log.formatter.line | |||
| level: debug | |||
| level: info | |||
There was a problem hiding this comment.
@watarukashii
こちらの設定は、ERROR発生時はdebug以上を出力するようにする、かなと思うんですが、ここもdeubgに変更する必要ありますか？
https://qiita.com/mkita_a/items/362a9dd7c824a3793ad1
There was a problem hiding this comment.
@chihiro-adachi
コメントありがとうございます。おっしゃるとおり、 ERROR発生時はdebug以上を出力する と存じます。
prod/monolog.logをdebugに変更いたしました。恐れ入ります。引き続きよろしくおねがいします。
|
@watarukashii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
現状、本番モードで
Deprecatedエラーや、同じようなログが大量に出力されているため本番モードのmonologの調整を行いました。
方針(Policy)
symfony/symfony#26267 (comment)
上記、symfonyのissue にならって作成。
#5082 (comment)
に記載したとおりですが、Deprecated 以外にも、不要かと思われるエラーを定義しました。
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目