Release 1.8 #24
Release 1.8 #24
Conversation
| @@ -1,486 +1,511 @@ | |||
| # Dynatrace OneAgent SDK for Java | |||
There was a problem hiding this comment.
It seems there is some kind of line ending issue here.
There was a problem hiding this comment.
Hm, weird. Does it matter though?
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| import com.dynatrace.oneagent.sdk.api.OutgoingMessageTracer; | |||
|
|
|||
| public class OutgoingMessageTracerProxy extends TraceableProxy implements OutgoingMessageTracer { | |||
| final class OutgoingMessageTracerProxy extends TraceableProxy implements OutgoingMessageTracer { | |||
There was a problem hiding this comment.
I recall we talked about something similar before, but why is public removed from this class? And why just this class?
There was a problem hiding this comment.
It's not just this class. It's all but OutgoingWebRequestTracerProxy which is probably an oversight.
These classes should never have been public (and non-final) in the first place. This will be mentioned in the GH release notes though.
There was a problem hiding this comment.
There is also SDK2AgentInternalApiProxy which is still public.
There was a problem hiding this comment.
This is actually intentional (or rather: necessary).
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| import com.dynatrace.oneagent.sdk.api.OutgoingMessageTracer; | |||
|
|
|||
| public class OutgoingMessageTracerProxy extends TraceableProxy implements OutgoingMessageTracer { | |||
| final class OutgoingMessageTracerProxy extends TraceableProxy implements OutgoingMessageTracer { | |||
There was a problem hiding this comment.
There is also SDK2AgentInternalApiProxy which is still public.
Updated `docs', 'src' and 'README.md' from BB repo.