10BC0 IDEV-2299: Validation and error handling improvements by jbabac · Pull Request #186 · DomainTools/python_api · GitHub
[go: up one dir, main page]
Skip to content

IDEV-2299: Validation and error handling improvements #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbabac merged 5 commits into from
Dec 9, 2025
Merged

IDEV-2299: Validation and error handling improvements #186

jbabac merged 5 commits into from
Dec 9, 2025

Conversation

@jbabac
Copy link
Contributor
@jbabac jbabac commented Dec 1, 2025

Change(s):

  1. Added RequestValidator to handle validation and error handling

Tests:

  1. UT:
image 2. E2E: image

@jbabac jbabac self-assigned this Dec 1, 2025
@briluza
Copy link
Contributor
briluza commented Dec 5, 2025 •
edited
Loading

Awesome job on this @jbabac .

Question:

  • Should we remove the validations inside the api functions? e.g in iris_investigate
     if not (kwargs or domains):
            raise ValueError("Need to define investigation using kwarg filters or domains")

     if isinstance(active, bool):
            kwargs["active"] = str(active).lower()

*Note (maybe a future enhancement): Should we also do type annotations so that it can help devs or users to see what is expected type in each parameters rather always looking in the openapi spec or using the help()?

briluza
briluza reviewed Dec 5, 2025
View reviewed changes
@jbabac
Copy link
Contributor Author
jbabac commented Dec 9, 2025

is_body_required

Yes we can.

Awesome job on this @jbabac .

Question:

  • Should we remove the validations inside the api functions? e.g in iris_investigate
     if not (kwargs or domains):
            raise ValueError("Need to define investigation using kwarg filters or domains")

     if isinstance(active, bool):
            kwargs["active"] = str(active).lower()

*Note (maybe a future enhancement): Should we also do type annotations so that it can help devs or users to see what is expected type in each parameters rather always looking in the openapi spec or using the help()?

Yes, we can. This has been addressed already.

@jbabac jbabac changed the base branch from release-2.6.2 to release-2.7.0 December 9, 2025 16:50
@jbabac jbabac merged commit 4e17f06 into release-2.7.0 Dec 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briluza briluza briluza approved these changes

Assignees

@jbabac jbabac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbabac @briluza
0