10000 [pull] master from ropensci:master by pull[bot] · Pull Request #2 · Displayr/plotly · GitHub
[go: up one dir, main page]

Skip to content

[pull] master from ropensci:master #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 115 commits into from
Mar 12, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
115 commits
Select commit Hold shift + click to select a range
7185252
New version of scales no longer 'spans the gamut' of a qualitative co…
cpsievert Dec 3, 2018
eb2caca
reduce Reduce() for merging lists
alyst Mar 18, 2019
db622ad
ensure_one(): reduce noise if attrs are NULL
alyst Mar 18, 2019
0b74e8d
ggplotly: fix Xaxis anchor if the last row incomplete
alyst Mar 18, 2019
414fbe1
stylistic changes
cpsievert Apr 3, 2019
8a8878d
validate new visual baselines
cpsievert Apr 3, 2019
51a8099
Merge branch 'master' into avoid_reduce
cpsievert Apr 4, 2019
8a5b8c3
merge conflicts
cpsievert Apr 4, 2019
51c7437
Merge branch 'master' into fix_wrap_axes
cpsievert Apr 8, 2019
3c85052
Doesn't seem like we need to handle yaxis being a factor
cpsievert Apr 8, 2019
8becdb9
update shinytest baselines
cpsievert Jul 10, 2019
5be39f7
ugh maintaining shinytest tests for htmlwidgets is a real pain
cpsievert Jul 10, 2019
6f151a7
Merge pull request #1557 from ropensci/v1.48
cpsievert Jul 10, 2019
2a439bc
update sf baselines
cpsievert Jul 13, 2019
a0fa68f
go back to using ggplotly() to prepare the widget for shiny rendering
cpsievert Jul 13, 2019
237f89d
Generation of non-intercept data in hline/vline should respect coord_…
cpsievert Jul 12, 2019
3bdb921
Merge pull request #1498 from alyst/avoid_reduce
cpsievert Jul 15, 2019
ddb8b30
merge with master
cpsievert Jul 15, 2019
3f3d875
Merge pull request #1501 from alyst/fix_wrap_axes
cpsievert Jul 15, 2019
ecf3b39
update news; fix typo
cpsievert Jul 15, 2019
5178c5d
Account for new changes in ggplot2's internal API, fixes #1561
cpsievert Jul 11, 2019
7efd029
include braces
cpsievert Jul 12, 2019
b6de355
gsub
cpsievert Jul 13, 2019
74b9168
moar braces
cpsievert Jul 16, 2019
9aaffa2
new sf baselines
cpsievert Jul 16, 2019
9a9876f
Merge pull request #1572 from ropensci/ggplot2-dev
cpsievert Jul 16, 2019
49da4f0
Merge pull request #1576 from ropensci/flip-lines
cpsievert Jul 17, 2019
a689263
update news
cpsievert Jul 17, 2019
40b1a1c
upgrade to plotly.js v1.49.0
cpsievert Jul 24, 2019
13ecba2
upgrade to plotly.js v1.49.2
cpsievert Aug 13, 2019
35c2bb3
upgrade to plotly.js v1.49.4
cpsievert Aug 26, 2019
3572a00
update baseline
cpsievert Aug 26, 2019
eeb33a1
update shinytest baseline
cpsievert Aug 27, 2019
d11bb5a
Merge pull request #1585 from ropensci/v1.49
cpsievert Aug 27, 2019
e07f80c
make a deep copy of x.layout.width/x.layout.height for use in the res…
cpsievert Aug 28, 2019
dd474e2
Wrap user-supplied expression in evalq(), closes #1528
cpsievert May 24, 2019
af1c770
Use shiny::installExprFunction to register debug hooks
cpsievert Aug 26, 2019
3867737
Asynchronously register plot events
cpsievert Aug 29, 2019
d416cea
Merge pull request #1539 from ropensci/renderWidgetPrep
cpsievert Aug 30, 2019
2856731
Revert "Merge pull request #1539 from ropensci/renderWidgetPrep"
cpsievert Aug 30, 2019
a0cd2f2
no need to be making deep copies
cpsievert Aug 30, 2019
8bc36b9
Improvements to algorithm for attaching key attribute for shiny's eve…
cpsievert Sep 3, 2019
8056cc5
When pointNumber is a constant, relay it as such
cpsievert Sep 3, 2019
81caeeb
handle the 3 cases separately
cpsievert Sep 3, 2019
30e3997
use idx instead of i
cpsievert Sep 3, 2019
17466a3
Merge pull request #1611 from ropensci/shiny-event-data-key
cpsievert Sep 3, 2019
972a4cb
update news
cpsievert Sep 3, 2019
6844d74
Call setInputValue only if it's defined, closes #1624
cpsievert Sep 23, 2019
08d402c
Merge pull request #1578 from ropensci/prepareWidget
cpsievert Oct 8, 2019
7fbb486
Revert "Revert "Merge pull request #1539 from ropensci/renderWidgetPr…
cpsievert Aug 30, 2019
1a714b8
pass along a quoted expr that calls func()
cpsievert Aug 30, 2019
3fd7e39
Merge pull request #1609 from ropensci/renderWidgetPrep2
cpsievert Oct 8, 2019
6f1925a
Merge pull request #1575 from ropensci/resize
cpsievert Oct 8, 2019
5c77075
Revert "go back to using ggplotly() to prepare the widget for shiny r…
cpsievert Oct 8, 2019
6ecca60
update news
cpsievert Oct 8, 2019
dcd4219
verify_webgl() shouldn't warn about types that are already gl, closes…
cpsievert Oct 8, 2019
4c0c7d8
Merge pull request #1625 from ropensci/static-shiny-render
cpsievert Oct 8, 2019
6d90509
fix test
cpsievert Oct 8, 2019
d41a675
Do not create structure with NULL to remove warnings
Oct 15, 2019
c299c5f
Fix management of environments in renderPlotly(), fixes #1639
cpsievert Oct 16, 2019
599b851
Add test to prove #1299 fix
Oct 19, 2019
5e1feb3
Merge pull request #1638 from wfjvdham/check_NA_for_lines
cpsievert Oct 21, 2019
c889fa2
proposed change to avoid peeking at 'grid' unit internals
pmur002 Oct 22, 2019
c708f76
improve previous commit
pmur002 Oct 23, 2019
7987280
Merge pull request #1646 from pmur002/master
cpsievert Oct 23, 2019
cdfdc7c
refactor Paul's unit type commits from #1646
cpsievert Oct 23, 2019
a3a1941
Some CRAN builds don't have pandoc
cpsievert Nov 2, 2019
f9b623e
Merge pull request #1421 from ropensci/scales
cpsievert Nov 6, 2019
4d83031
Merge branch 'master' of github.com:ropensci/plotly
cpsievert Nov 6, 2019
8108b20
plot_mapbox() shouldn't force a scattermapbox trace type, closes #1608
cpsievert Nov 6, 2019
daf0c35
fix R CMD check notes
cpsievert Nov 6, 2019
3cbccfc
r-devel apparently doesn't yet have grid::unitType()
cpsievert Nov 6, 2019
6553f8b
remove outdated travis config
cpsievert Nov 6, 2019
290c8ef
Validate changes visual baselines due to changes in R3.6's new RNG me…
cpsievert Nov 6, 2019
bcae42b
Add support for new plotly_sunburstclick event, closes #1648
cpsievert Nov 6, 2019
683aa1b
validate new shinytest baselines
cpsievert Nov 6, 2019
ff27ca5
update news
cpsievert Nov 6, 2019
7b32e7e
fix silly mistake from 3cbccfc508ed239e99739cc816ebf9067e019674
cpsievert Nov 7, 2019
ba86b9d
document
cpsievert Nov 7, 2019
71da78c
test expectation should account for changes in the default color pale…
cpsievert Nov 7, 2019
2bbb5dc
improve the aforementioned test example and add a visual test
cpsievert Nov 7, 2019
27db11e
Ignore calculated aesthetics that match specified aesthestics
cpsievert Oct 2, 2019
bfafb5e
fix broken link raster2uri and improve the description
cpsievert Nov 7, 2019
bf08221
cran hyperlinks must be https
cpsievert Nov 7, 2019
b5cbae3
fix roxygen warning
cpsievert Nov 7, 2019
006b69a
In contrast to attr(x, unit), the new grid::unitType() function alway…
cpsievert Nov 7, 2019
9bcf90a
bump to release version; submit to CRAN
cpsievert Nov 7, 2019
c037c68
Respect sf's plot12 graticule attribute when building axis ticks, fix…
cpsievert Dec 26, 2019
63eaf39
Remove missing values in ticktext/tickvals
cpsievert Jan 6, 2020
e85ee24
link to comment
cpsievert Jan 6, 2020
9f6fa20
remove outdated/bad test expectation...the visual baseline covers it
cpsievert Jan 6, 2020
669db9c
Merge pull request #1650 from ropensci/ggplotly-calculated-tooltip
cpsievert Jan 7, 2020
c47c1f9
Merge pull request #1679 from ropensci/ggplotly-missing-ticks
cpsievert Jan 7, 2020
7d2ea6d
Don't assume sf geometry is always accessible via [['geometry']], fix…
cpsievert Feb 4, 2020
c3fe34b
validate baselines
cpsievert Feb 5, 2020
eb0a460
update news
cpsievert Feb 5, 2020
af255a7
update to plotly.js 1.52.2
cpsievert Feb 4, 2020
91a0826
new baselines
cpsievert Feb 5, 2020
397e289
Add image and treemap visual tests. Also, ensure treemap's stroke ref…
cpsievert Feb 5, 2020
7ffa87f
Add Object.setPrototypeOf polyfill for shinytest and update shinytest…
cpsievert Feb 6, 2020
cabc57d
Add add_image() for easier rendering of image traces via raster objects
cpsievert Feb 6, 2020
7f7a60d
Merge pull request #1690 from ropensci/sf-geometry
cpsievert Feb 6, 2020
cead5d9
Merge pull request #1695 from ropensci/v1.52
cpsievert Feb 6, 2020
d6a95cf
Bump version, update news, document, add unit test for add_image()
cpsievert Feb 6, 2020
37a2708
roxygen escapes % now
cpsievert Feb 6, 2020
65493ad
Only call locale_dependency() for locales not included with standard …
cpsievert Feb 6, 2020
a63b048
CRAN submission
cpsievert Feb 12, 2020
1e243ba
plot_mapbox() should default to scattermapbox unless z is present, fi…
cpsievert Feb 24, 2020
f8af657
Merge pull request #1674 from ropensci/sf-plot12-ticks
cpsievert Mar 4, 2020
684c779
Merge pull request #1635 from ropensci/verify-webgl
cpsievert Mar 4, 2020
9e427fc
add visual test for #1674
cpsievert Mar 4, 2020
273c4ed
update poor test expectations that assume stringsAsFactors defaults t…
cpsievert Mar 4, 2020
0906548
bump version; update news
cpsievert Mar 4, 2020
25b28c9
update visual tests
cpsievert Mar 4, 2020
33fc723
remove rnaturalearth dependency in tests
cpsievert Mar 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update visual tests
  • Loading branch information
cpsievert committed Mar 4, 2020
commit 25b28c93250b4a6ef8681687644dc6e94da8338c
1 change: 1 addition & 0 deletions inst/docker/Dockerfile.vtest
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ RUN R -e "install.packages('testthat')"
ARG CRANCACHE=1
RUN R -e "update.packages(ask=FALSE)"
RUN R -e "remotes::install_github('r-lib/vdiffr')"
RUN R -e "install.packages('rnaturalearth')"

# install any new dependencies, then either manage cases (the default) or run tests
# note the workaround to get docker to run a proper exit status when there are testthat errors
Expand Down
2 changes: 1 addition & 1 deletion tests/figs/abline/cookbook-axes-multiple-abline.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions tests/figs/geom-sf/sf-axis-ticks.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/plotly/plotly-bar-inference.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/plotly/plotly-time-series-summary.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/subplot/plotly-subplot-shareboth.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/subplot/plotly-subplot-simple.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/tooltip/group-lines-hovertext.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/figs/tooltip/hovertext-display.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/testthat/test-ggplot-sf.R
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ test_that("resolves overlapping axis ticks", {
world <- rnaturalearth::ne_countries(returnclass = "sf")

# filter the world sf object down to canada
canada <- rnaturalearth::filter(world, name == "Canada")
canada <- dplyr::filter(world, name == "Canada")
# coerce cities lat/long data to an official sf object
cities <- sf::st_as_sf(
maps::canada.cities,
Expand All @@ -134,5 +134,5 @@ test_that("resolves overlapping axis ticks", {
p <- ggplot() +
geom_sf(data = canada) +
geom_sf(data = cities, aes(size = pop), color = "red", alpha = 0.3)
ggplotly(p)
expect_doppelganger_built(ggplotly(p), "sf-axis-ticks")
})
0