8000 Move conv rev diff ops out of main loop by dsyme · Pull Request #90 · DiffSharp/DiffSharp · GitHub
[go: up one dir, main page]
Skip to content

Move conv rev diff ops out of main loop #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

Move conv rev diff ops out of main loop #90

merged 1 commit into from
Mar 2, 2020

Conversation

dsyme
Copy link
Collaborator
@dsyme dsyme commented Mar 2, 2020

@gbaydin I moved the reverse gradient computations for conv1d and conv2d out of the main reverse gradient algorithm - after we do #89 we will move them to a separate file in any case.

I'll pull this as I'll do batching for conv1d as part of #88 and the change is otehrwise cosmetic - please adjust the names of the (internal) operations as you see fit.

@dsyme dsyme merged commit af8083b into dev Mar 2, 2020
@dsyme
Copy link
Collaborator Author
dsyme commented Mar 2, 2020

(The conv ops already suppoirt batching but I think it's right to move the reverse parts out of the differentiation loop - they belong next to the main op)

@dsyme dsyme deleted the clean4 branch May 5, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsyme
0