8000 feature/permute - permute by dsyme · Pull Request #254 · DiffSharp/DiffSharp · GitHub
[go: up one dir, main page]
Skip to content

feature/permute - permute #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 30, 2020
Merged

feature/permute - permute #254

merged 6 commits into from
Nov 30, 2020

Conversation

dsyme
Copy link
Collaborator
@dsyme dsyme commented Nov 26, 2020

Add Tensor.permute, resolves #193

Derivatives are simple enough, I made sure there was a test for a rotation

@gbaydin please check

@dsyme dsyme mentioned this pull request Nov 26, 2020
Open
22 tasks
@codecov
Copy link
codecov bot commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #254 (334b51f) into dev (200df6c) will increase coverage by 0.59%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #254      +/-   ##
==========================================
+ Coverage   64.07%   64.66%   +0.59%     
==========================================
  Files          19       19              
  Lines        5555     6100     +545     
  Branches     1406     1446      +40     
==========================================
+ Hits         3559     3944     +385     
- Misses       1231     1378     +147     
- Partials      765      778      +13
Impacted Files Coverage Δ
src/DiffSharp.Core/DiffSharp.fs 52.28% <0.00%> (+21.19%) ⬆️
src/DiffSharp.Core/RawTensor.fs 85.62% <ø> (-0.38%) ⬇️
src/DiffSharp.Core/Shape.fs 52.98% <60.00%> (+5.04%) ⬆️
src/DiffSharp.Core/Tensor.fs 62.52% <63.64%> (-9.58%) ⬇️
...iffSharp.Backends.Reference/Reference.RawTensor.fs 60.86% <93.33%> (+2.15%) ⬆️
src/DiffSharp.Backends.Torch/Torch.RawTensor.fs 79.14% <100.00%> (+0.33%) ⬆️
src/DiffSharp.Core/Extensions.fs 55.45% <100.00%> (+4.45%) ⬆️
src/DiffSharp.Core/DiffSharp.Numerical.fs 77.63% <0.00%> (-3.95%) ⬇️
src/DiffSharp.Core/Scalar.fs 8.33% <0.00%> (-0.49%) ⬇️
... and 15 more

@dsyme dsyme changed the title feature/permute feature/permute - permute Nov 28, 2020
@gbaydin
Copy link
Member
gbaydin commented Nov 30, 2020

Checking now

@gbaydin
Copy link
Member
gbaydin commented Nov 30, 2020

This looks good now, let's merge

@gbaydin gbaydin closed this Nov 30, 2020
@gbaydin gbaydin reopened this Nov 30, 2020
@gbaydin gbaydin merged commit 1213767 into dev Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement permute
2 participants
@dsyme @gbaydin
0