E52C feat: Add alt optional copy HTML to clipboard on demo site by R055A · Pull Request #608 · DenverCoder1/github-readme-streak-stats · GitHub
[go: up one dir, main page]
Skip to content

feat: Add alt optional copy HTML to clipboard on demo site#608

Merged
DenverCoder1 merged 3 commits intoDenverCoder1:mainfrom
R055A:demo-alt-html-output-type
Oct 3, 2023
Merged

feat: Add alt optional copy HTML to clipboard on demo site#608
DenverCoder1 merged 3 commits intoDenverCoder1:mainfrom
R055A:demo-alt-html-output-type

Conversation

@R055A
Copy link
Contributor
@R055A R055A commented Oct 2, 2023

Description

Add alternative option for copying HTML to the clipboard on the demo site.

Fixes #572

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

light

dark

Haven't included images for entering a valid username, but can verify both Copy to Clipboard buttons enable

DenverCoder1
DenverCoder1 reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner
@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just have a minor suggestion.

Another thing to consider is maybe making a JSON Endpoint section appear when the type is set to JSON instead of having HTML and Markdown, but that can be saved for another PR if you prefer.

@R055A
Copy link
Contributor Author
R055A commented Oct 3, 2023

Looks great, I just have a minor suggestion.

Another thing to consider is maybe making a JSON Endpoint section appear when the type is set to JSON instead of having HTML and Markdown, but that can be saved for another PR if you prefer.

It may be better to make a new PR for the JSON clipboard feature. If you assign me to a new Issue for the JSON clipboard I can make a PR for it by today or tomorrow (depending time zone).

DenverCoder1
DenverCoder1 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Owner
@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit f5aeeca into DenverCoder1:main Oct 3, 2023
@DenverCoder1 DenverCoder1 changed the title Add alt optional copy HTML to clipboard on demo site feat: Add alt optional copy HTML to clipboard on demo site Oct 3, 2023
@DenverCoder1 DenverCoder1 mentioned this pull request Oct 3, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Demo site feature: Add alternate output types on the demo site

2 participants

@R055A @DenverCoder1
0