E533 fix: Corrected Portuguese translation by ThiagoZulian · Pull Request #538 · DenverCoder1/github-readme-streak-stats · GitHub
[go: up one dir, main page]
Skip to content

fix: Corrected Portuguese translation#538

Merged
DenverCoder1 merged 1 commit intoDenverCoder1:mainfrom
ThiagoZulian:patch-1
Jun 27, 2023
Merged

fix: Corrected Portuguese translation#538
DenverCoder1 merged 1 commit intoDenverCoder1:mainfrom
ThiagoZulian:patch-1

Conversation

@ThiagoZulian
Copy link
Contributor
@ThiagoZulian ThiagoZulian commented Jun 26, 2023

Description

Just updated one translation to a more natural language in brazilian portuguese.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@DenverCoder1
Copy link
Owner
DenverCoder1 commented Jun 26, 2023

This change seems to revert #527. What do you think about the reasons mentioned there?

@ThiagoZulian
Copy link
Contributor Author
ThiagoZulian commented Jun 27, 2023

I'm sorry that I haven't seen that PR before, I'll make sure to keep my eyes on it next time.

I think you can keep as it is, but still "Contribuições Totais" sounds more like the contributions that were made till the end. That are completed OR the Overall maded contributions.
"Total de contribuições" sounds like The total of contributions

Since you can't make half a contribution, It just don't sounds right in portuguese when you say that you made a contribution by its total, as it sounds right now.

Anyway, whichever sentences you choose are ok and it might not bring too much confusion to anyone, these are just small details of my language.

@DenverCoder1
Copy link
Owner
DenverCoder1 commented Jun 27, 2023 •
edited
Loading

I asked some others and it seems like most people agree with this.

Thanks for contributing!

@DenverCoder1 DenverCoder1 changed the title pt_BR translation correction fix: Corrected Portuguese translation Jun 27, 2023
@DenverCoder1 DenverCoder1 merged commit 153e4f7 into DenverCoder1:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThiagoZulian @DenverCoder1
0