Modified puls #323
Merged
Modified puls #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inflow and outflow variables for the lake module are defined for dt, so the terms (Qin1 (t1) + Qin2 (t2))/2 and (Qout1 (t1) + Qout2 (t2))/2 as in the original mass balance equation of the Modified Puls Approach are not required. Because of this the terms of the quadratic equation were fixed (the solution of the quadratic equation based on the original mass balance equation was implemented.
JoostBuitink
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Issue was not reported.
Explanation
See changelog and first commit.
Checklist
master