8000 mongodb.d.ts fixes to enable Promise and async-await by davetemplin · Pull Request #9064 · DefinitelyTyped/DefinitelyTyped · GitHub
[go: up one dir, main page]
Skip to content

mongodb.d.ts fixes to enable Promise and async-await #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2016
Merged

mongodb.d.ts fixes to enable Promise and async-await #9064

merged 2 commits into from
Apr 25, 2016

Conversation

davetemplin
Copy link
Contributor
@davetemplin davetemplin commented Apr 21, 2016 •
edited
Loading

Various fixes to enable Promise and async-await scenarios...

  • Db.command: fix incorrect function overload signature
  • Collection.aggregate: fix incorrect function overload signature
  • Collection.find: add missing overload signature
  • Collection.findOne: add missing interface function
  • Collection.initializeOrderedBulkOp: make option parameter optional
  • Collection.initializeUnorderedBulkOp: make option parameter optional
  • Collection.insert: add missing interface function
  • Collection.update: add missing interface function
  • Collection.save: add missing interface function
  • OrderedBulkOperation.execute: fix incorrect function overload signature
  • UnorderedBulkOperation.execute: fix incorrect function overload signature
  • toArray() of CommandCursor and AggregationCursor should return any[] instead of Object[]
  • dropCollection of Db returns a boolean

Fix spelling errors: CollectionAggrigationOptions -> CollectionAggregationOptions
Flag legacy functions as deprecated (see future TypeScript 2.1 feature)

@dt-bot
Copy link
Member
dt-bot commented Apr 21, 2016 •
edited by vvakame
Loading

mongodb/mongodb.d.ts

to author (@CaselIT). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@CaselIT
Copy link
Contributor
CaselIT commented Apr 21, 2016

Great thanks for the help! 👍
I think you can now close the other pr #9024

@CaselIT CaselIT mentioned this pull request Apr 21, 2016
Closed
@CaselIT
Copy link
Contributor
CaselIT commented Apr 21, 2016 •
edited
Loading

@davetemplin I've found some other imprecisions.

  • toArray() of CommandCursor and AggregationCursor should return any[] instead of Object[]
  • dropCollection of Db returns a boolean

I've added them on typings-mongodb

@davetemplin
Copy link
Contributor Author

OK just updated this PR with your latest changes.

@davetemplin
Copy link
Contributor Author

Just checking--is there anything else that is needed to get this PR merged into the GitHub master?

@CaselIT
Copy link
Contributor
CaselIT commented Apr 23, 2016

No, just waiting I think 👍

@vvakame vvakame merged commit b97c0d5 into DefinitelyTyped:master Apr 25, 2016
@davetemplin
Copy link
Contributor Author

Looking good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davetemplin @dt-bot @CaselIT @vvakame @PS-davetemplin
0