[@types/node] correct LoadFnOutput.format
#72581
Conversation
|
@boneskull Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72581,
"author": "boneskull",
"headCommitOid": "563d46ce7c5428ce1d5ef49362a03cba09d9a601",
"mergeBaseOid": "56fa141477f35c3997da2e8134786ac52847fe98",
"lastPushDate": "2025-04-23T21:44:54.000Z",
"lastActivityDate": "2025-05-29T22:30:48.000Z",
"mergeOfferDate": "2025-05-29T21:49:38.000Z",
"mergeRequestDate": "2025-05-29T22:30:48.000Z",
"mergeRequestUser": "boneskull",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v18/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v20/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/module.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2025-05-29T21:49:00.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "Bashamega",
"date": "2025-05-07T03:25:32.000Z",
"abbrOid": "9960c49"
},
{
"type": "stale",
"reviewer": "JakobJingleheimer",
"date": "2025-04-25T08:22:59.000Z",
"abbrOid": "9960c49"
},
{
"type": "stale",
"reviewer": "Renegade334",
"date": "2025-04-24T19:45:56.000Z",
"abbrOid": "74b18d3"
}
],
"mainBotCommentID": 2825568024,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
4c98399 to
7129a6b
Compare
|
@boneskull The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
The failure is unrelated. Not sure what I need to do to get eyes on this. |
|
cc @JakobJingleheimer – WDYR?
This is an unfortunate limitation of DT – will need some upstream housekeeping before this PR is released for review. |
|
EDIT: Ah, I see the problem. It's impossible for typescript to guard the end of the chain. So effectively, yes. |
7129a6b to
74b18d3
Compare
|
@Renegade334, @JakobJingleheimer Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
Does this need to update other versions of Node or is just the latest fine? |
|
Other versions (all that support loaders, I believe) |
|
Is anything else needed from me here? |
|
Yes, I believe this change needs to be mirrored to the versioned subdirectories. |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @boneskull. (Ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.) |
A `LoadHook` accepts a `LoadHookContext` object having a `format` of `string | null | undefined`. `LookHook` implementors often want to pass this value through ([example from docs](https://nodejs.org/api/module.html\#asynchronous-version), which suggests to me that a) it can be falsy, and b) it should be a looser type as established for `ResolveFnOutput` in DefinitelyTyped#71493).
9960c49 to
563d46c
Compare
|
@jakebailey I've backported the changes. |
|
@Bashamega, @JakobJingleheimer, @Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@boneskull: Everything looks good here. I am ready to merge this PR (at 563d46c) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
A
LoadHookaccepts aLoadHookContextobject having aformatofstring | null | undefined.LookHookimplementors often want to pass this value through (example from docs, which suggests to me that a) it can be falsy, and b) it should be a looser type as established forResolveFnOutputin #71493).A consequence of this is thatUPDATE: This has been reverted;ModuleFormatis no longer referenced anywhere; it can be removed.ModuleFormathas not been removed.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
ResolveFnOutput.format(can be intermediary) #71493package.json.