Update Plotlyjs to support subtitle #72148
Conversation
|
@kojo12228 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72148,
"author": "kojo12228",
"headCommitOid": "725ddc16e00edc6e0b1ce18d1ac5214b01359fbe",
"mergeBaseOid": "0d9acac45f4b9729d5801fac116c05fe974a9b4f",
"lastPushDate": "2025-03-07T18:58:23.000Z",
"lastActivityDate": "2025-03-28T19:19:37.000Z",
"mergeOfferDate": "2025-03-28T17:34:14.000Z",
"mergeRequestDate": "2025-03-28T19:19:37.000Z",
"mergeRequestUser": "kojo12228",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "plotly.js",
"kind": "edit",
"files": [
{
"path": "types/plotly.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/plotly.js/test/core-tests.ts",
"kind": "test"
}
],
"owners": [
"chrisgervang",
"martinduparc",
"frederikaalund",
"taoqf",
"Dadstart",
"szechyjs",
"soorajpudiyadath",
"jonfreedman",
"meganrm",
"milesjos",
"skippercool",
"marnett-git",
"peterblazejewicz",
"brammitch",
"blizzardjessica",
"olegshilov",
"PabloGracia",
"jvgogh",
"jpabdou",
"mrtnbrst"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
<
8000
span class="pl-ent">"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2025-03-28T17:33:34.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2707192882,
"ciResult": "pass"
} |
|
🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov @PabloGracia @jvgogh @jpabdou @mrtnbrst — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh, @jpabdou, @mrtnbrst: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @kojo12228. (Ping @chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh, @jpabdou, @mrtnbrst.) |
|
@kojo12228: Everything looks good here. I am ready to merge this PR (at 725ddc1) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh, @jpabdou, @mrtnbrst: you can do this too.) |
|
Ready to merge |
Add relatively new
subtitlesupport tolayout.title.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.