-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Plotly legendgrouptitle, legendrank #65994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotly legendgrouptitle, legendrank #65994
Conversation
Added missing properties of PlotData legendgrouptitle: plotly/plotly.js#5260 Plotly attributes file with legendgrouptitle and legendrank right below: https://github.com/plotly/plotly.js/blob/ab5e16afc34fa4f22efffef129f811381580e0fe/src/plots/attributes.js#L57
…nitelyTyped into plotly-legendgroup
@mrtnbrst Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65994,
"author": "mrtnbrst",
"headCommitOid": "8d91330b6db2b60fa3bad1ffae3d0262bac6f119",
"mergeBaseOid": "e42746838dabadb4aa0542017f178a3c118f4e18",
"lastPushDate": "2023-07-06T15:24:20.000Z",
"lastActivityDate": "2023-07-09T17:17:00.000Z",
"mergeOfferDate": "2023-07-08T12:31:46.000Z",
"mergeRequestDate": "2023-07-09T17:17:00.000Z",
"mergeRequestUser": "mrtnbrst",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "plotly.js",
"kind": "edit",
"files": [
{
"path": "types/plotly.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/plotly.js/test/index-tests.ts",
"kind": "test"
}
],
"owners": [
"chrisgervang",
"martinduparc",
"frederikaalund",
"taoqf",
"Dadstart",
"szechyjs",
"soorajpudiyadath",
"jonfreedman",
"meganrm",
"milesjos",
"skippercool",
"mtadams007",
"marnett-git",
"peterblazejewicz",
"brammitch",
"blizzardjessica",
"olegshilov",
"PabloGracia",
"jvgogh",
"jpabdou"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-07-08T12:31:01.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1623875993,
"ciResult": "pass"
} |
🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov @PabloGracia @jvgogh @jpabdou — please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. plotly.js (unpkg)was missing the following properties:
|
@mrtnbrst your test file changes seem to not include any actual change, except of format changes. Was that expected? |
As mentioned in the initial message, I couldn't even make the current tests work. Unfortunatelly my JavaScript / TypeScript knowledge is too little to figure out what's wrong. If we can make the current tests work (maybe it's just an issue on my machine), I can try to write a test for the change.
The test file changed as it was, wasn't properly formatted - I ran the formatter as described in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mrtnbrst thanks!
@mrtnbrst: Everything looks good here. I am ready to merge this PR (at 8d91330) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @mtadams007, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh, @jpabdou: you can do this too.) |
Ready to merge |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Plotly tests on master crash (on my machine), currently no plotly groups are used in the tests, so no need for editing those
Follow the advice from the readme.
Avoid common mistakes.
Note: I ran prettier with the npm command which lead to a test file being changed.
Run
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
Provide a URL to documentation or source code which provides context for the suggested changes:
legendgrouptitle: legendgroup titles plotly/plotly.js#5260
Plotly attributes file with legendgrouptitle and legendrank right below:
https://github.com/plotly/plotly.js/blob/ab5e16afc34fa4f22efffef129f811381580e0fe/src/plots/attributes.js#L57
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
I don't have enough knowledge of plotly to assess if this makes it up to date with a version number, in doubt it does not.