8000 Plotly legendgrouptitle, legendrank by mrtnbrst · Pull Request #65994 · DefinitelyTyped/DefinitelyTyped · GitHub
[go: up one dir, main page]

Skip to content

Plotly legendgrouptitle, legendrank #65994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2023

Conversation

mrtnbrst
Copy link
Contributor
@mrtnbrst mrtnbrst commented Jul 6, 2023

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.

  • Test the change in your own code. (Compile and run.)

  • Add or edit tests to reflect the change.
    Plotly tests on master crash (on my machine), currently no plotly groups are used in the tests, so no need for editing those

  • Follow the advice from the readme.

  • Avoid common mistakes.
    Note: I ran prettier with the npm command which lead to a test file being changed.

  • Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor
typescript-bot commented Jul 6, 2023

@mrtnbrst Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65994,
  "author": "mrtnbrst",
  "headCommitOid": "8d91330b6db2b60fa3bad1ffae3d0262bac6f119",
  "mergeBaseOid": "e42746838dabadb4aa0542017f178a3c118f4e18",
  "lastPushDate": "2023-07-06T15:24:20.000Z",
  "lastActivityDate": "2023-07-09T17:17:00.000Z",
  "mergeOfferDate": "2023-07-08T12:31:46.000Z",
  "mergeRequestDate": "2023-07-09T17:17:00.000Z",
  "mergeRequestUser": "mrtnbrst",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "plotly.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/plotly.js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/plotly.js/test/index-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "chrisgervang",
        "martinduparc",
        "frederikaalund",
        "taoqf",
        "Dadstart",
        "szechyjs",
        "soorajpudiyadath",
        "jonfreedman",
        "meganrm",
        "milesjos",
        "skippercool",
        "mtadams007",
        "marnett-git",
        "peterblazejewicz",
        "brammitch",
        "blizzardjessica",
        "olegshilov",
        "PabloGracia",
        "jvgogh",
        "jpabdou"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-07-08T12:31:01.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1623875993,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jul 6, 2023
@typescript-bot
Copy link
Contributor

🔔 @chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov @PabloGracia @jvgogh @jpabdou — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

plotly.js (unpkg)

was missing the following properties:

  1. version
  2. Fx
  3. Snapshot
  4. PlotSchema

Generated by 🚫 dangerJS against 8d91330

@peterblazejewicz
Copy link
Member

@mrtnbrst your test file changes seem to not include any actual change, except of format changes. Was that expected?

@mrtnbrst
Copy link
Contributor Author
mrtnbrst commented Jul 6, 2023

@peterblazejewicz

As mentioned in the initial message, I couldn't even make the current tests work. Unfortunatelly my JavaScript / TypeScript knowledge is too little to figure out what's wrong. If we can make the current tests work (maybe it's just an issue on my machine), I can try to write a test for the change.

Plotly tests on master crash (on my machine), currently no plotly groups are used in the tests, so no need for editing those


Note: I ran prettier with the npm command which lead to a test file being changed.

The test file changed as it was, wasn't properly formatted - I ran the formatter as described in the common mistakes section, so yes, it it intended to commit the style change of the test file without any 'actual' change.

Copy link
Member
@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mrtnbrst thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 8, 2023
@typescript-bot
Copy link
Contributor

@mrtnbrst: Everything looks good here. I am ready to merge this PR (at 8d91330) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@chrisgervang, @martinduparc, @frederikaalund, @taoqf, @Dadstart, @szechyjs, @soorajpudiyadath, @jonfreedman, @meganrm, @milesjos, @SkipperCool, @mtadams007, @marnett-git, @peterblazejewicz, @brammitch, @blizzardjessica, @olegshilov, @PabloGracia, @jvgogh, @jpabdou: you can do this too.)

@mrtnbrst
Copy link
Contributor Author
mrtnbrst commented Jul 9, 2023

Ready to merge

@typescript-bot typescript-bot merged commit 23c4367 into DefinitelyTyped:master Jul 9, 2023
@mrtnbrst mrtnbrst deleted the plotly-legendgroup branch July 9, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0